1571214 - Video is shifted down in Picture-in-Picture player window

Status: VERIFIED FIXED

(Toolkit :: Video/Audio Controls, defect, P2)

Description

[Winson Wen]

Attachment: Annotation 2019-08-04 012919.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:70.0) Gecko/20100101 Firefox/70.0

Steps to reproduce:

1. Open http://asianwiki.com/Your_Lie_in_April, or any other page with trailer on asianwiki.com
2. Scroll down the trailers section of the page and play one
3. Toggle PiP

Actual results:

Video is shifted down in the PiP window, with the bottom cut off and white space at the top.

Expected results:

Video is properly positioned.

This might be a dupe of Bug 1550002 but it doesn't mention the bottom being cut off so I'm not sure.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1571214 - Make sure to strip any element styles on the cloned <video> before inserting into the Picture-in-Picture player window. r?JSON_Voorhees

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1571214 - Regression test. r?JSON_Voorhees

Depends on D42006

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7f553ffa3787
Make sure to strip any element styles on the cloned <video> before inserting into the Picture-in-Picture player window. r=JSON_voorhees
https://hg.mozilla.org/integration/autoland/rev/f4201a5b783a
Regression test. r=JSON_voorhees

Comment 4

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/7f553ffa3787
https://hg.mozilla.org/mozilla-central/rev/f4201a5b783a

Comment 6

[Timea Cernea [:tbabos][inactive]]

Hey Winson,

Wanted to verify the fix for this issue but was quite confused on how did PiP work on this video first of all. For me, it uses Flash player and last time I checked PiP does not support Flash video players. Did you enforce PiP somehow or I am missing out something?

Comment 7

[Winson Wen]

Hmm, video plays fine without Flash for me, and I didn't have to change anything to get PiP to work. I don't have Flash installed though, so maybe the website is offering a Flash video because you have it installed?

Comment 8

[Timea Cernea [:tbabos][inactive]]

Thanks Winson!
Indeed flash was the problem here, uninstalled it and now I can play the video and PiP also works on the latest Beta 70.0b7 (64-bit) on Windows 10 x64.

Closing this as Verified - Fixed.