Closed Bug 1571267 Opened 3 months ago Closed 3 months ago

Port bug 1569375 - Refactor panel CSS to reduce shadow DOM traversal after CE conversion

Categories

(Thunderbird :: Theme, task)

task
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 70.0

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(2 files, 1 obsolete file)

We should follow this as we have also identical code from the customizableui copy.
The Update panel has actually also a unwanted padding in it.

This is a port of https://hg.mozilla.org/mozilla-central/rev/d1481ad9673d

I also changed code we actually don't use like for the widget-overflow to be in sync with FF. If this code should be removed this should be addressed in another bug. Maybe after the toolbar conversion we use it.

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9082883 - Flags: review?(mkmelin+mozilla)

The editContactPanel had also such a traversal.

Attachment #9082883 - Attachment is obsolete: true
Attachment #9082883 - Flags: review?(mkmelin+mozilla)
Attachment #9082885 - Flags: review?(mkmelin+mozilla)
Comment on attachment 9082885 [details] [diff] [review]
1571267-CSS-reduce-shadow-DOM-traversal.patch

Review of attachment 9082885 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, r=mkmelin
Attachment #9082885 - Flags: review?(mkmelin+mozilla) → review+
Keywords: checkin-needed

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/873534a28550
Port bug 1569375: Refactor panel CSS to reduce shadow DOM traversal after CE conversion. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 70.0
Version: unspecified → Trunk

I missed the extension install panel. Without this patch the panel has a padding of 10px and the buttons don't touch the border.

Attachment #9083452 - Flags: review?(mkmelin+mozilla)
Attachment #9083452 - Flags: review?(mkmelin+mozilla) → review+
Keywords: checkin-needed

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/21e4751b03ef
Follow-up: Add "panel-no-padding" class to the extension install panel too. r=mkmelin DONTBUILD

Keywords: checkin-needed
You need to log in before you can comment on or make changes to this bug.