1571287 - Add isShowingJunkNotification function to SeaMonkey mail component.

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, enhancement)

Description

[Frank-Rainer Grahl (:frg)]

The isShowingJunkNotification() function is missing from SeaMonkey. It was added to Thunderbird in bug 562048.

The latest version of the lookout add-on no longer works in SeaMonkey because of this.

https://addons.thunderbird.net/en-US/thunderbird/addon/lookout-fix-version/

Comment 1

[Frank-Rainer Grahl (:frg)]

Attachment: 1571287-add-isShowingJunkNotification-52.patch

Just add the missing function for 2.49.5. r+ a+ from IanN over irc.

ewong how far are you with the Windows 2.49.5 uploads. IanN needs to do a linux plus macOS build because of a missing l10n patch but Windows is basically done. I would only add this to 2.49.5 and do a new Windows build if it does not cause a problem for you.

Comment 2

[Frank-Rainer Grahl (:frg)]

Attachment: 1571287-add-isShowingJunkNotification.patch

Add the missing function and aligns its usage with Thunderbird.

[Approval Request Comment]
Regression caused by (bug #): --
User impact if declined: lookout add-on not working
Testing completed (on m-c, etc.): 2.53
Risk to taking this patch (and alternatives if risky): 2.53 is still in development so not risky.
String changes made by this patch: none

Comment 3

[Ian Neal]

Comment on attachment 9082898 [details] [diff] [review]
1571287-add-isShowingJunkNotification.patch

[Triage Comment]
LGTM r/a=me

Comment 4

[Edmund Wong (:ewong)]

(In reply to Frank-Rainer Grahl (:frg) from comment #1)

Created attachment 9082897 [details] [diff] [review]
1571287-add-isShowingJunkNotification-52.patch

Just add the missing function for 2.49.5. r+ a+ from IanN over irc.

ewong how far are you with the Windows 2.49.5 uploads. IanN needs to do a linux plus macOS build because of a missing l10n patch but Windows is basically done. I would only add this to 2.49.5 and do a new Windows build if it does not cause a problem for you.

No worries. Uploaded build2 already today.

When build3 is available to be processed, I should be able to quickly upload it. My next plan is to have a local system that'd send the files to a staging system.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/97f7da288241
Add isShowingJunkNotification for LookOut add-on. r=IanN

Comment 6

[Frank-Rainer Grahl (:frg)]

Target 2.49.5 build 3 (locally applied)
https://hg.mozilla.org/releases/comm-esr52/rev/799f475c3fc52cfc9eb8c3d5b87e7a0006790b7b
Hopefully the last one.

https://hg.mozilla.org/releases/comm-esr60/rev/bee6a4cc555f5f324936c6029cbc6a46ceab14dc