157132 - [ps] nsRenderingContextPS::SetClipRect mishandles nsClipCombine_kIntersect

Status: RESOLVED INVALID

(Core :: Printing: Output, defect)

Description

[Peter Niemayer]

I'm either completely misunderstanding something or the implementation of
nsRenderingContextPS::SetClipRect does something completely wrong:

The cases "aCombine == nsClipCombine_kIntersect" and "aCombine ==
nsClipCombine_kUnion" are handled exactly with the same code though they are
certainly supposed to do something quite different, aren't they?
  
  if (aCombine == nsClipCombine_kIntersect){
    mPSObj->newpath();
    mPSObj->moveto( NS_PIXELS_TO_POINTS(trect.x), NS_PIXELS_TO_POINTS(trect.y));
    mPSObj->box(NS_PIXELS_TO_POINTS(trect.width),
NS_PIXELS_TO_POINTS(trect.height));
    mPSObj->closepath();
    mPSObj->clip();
  } else if (aCombine == nsClipCombine_kUnion){
    mPSObj->newpath();
    mPSObj->moveto( NS_PIXELS_TO_POINTS(trect.x), NS_PIXELS_TO_POINTS(trect.y));
    mPSObj->box(NS_PIXELS_TO_POINTS(trect.width),
NS_PIXELS_TO_POINTS(trect.height));
    mPSObj->closepath();
    mPSObj->clip();
  }else ...

I want to know about this because I'd like to know how to do it right for a
different RenderingContext...

Comment 1

[rods (gone)]

-->

Comment 2

[Gervase Markham [:gerv]]

This is an automated message, with ID "auto-resolve01".

This bug has had no comments for a long time. Statistically, we have found that
bug reports that have not been confirmed by a second user after three months are
highly unlikely to be the source of a fix to the code.

While your input is very important to us, our resources are limited and so we
are asking for your help in focussing our efforts. If you can still reproduce
this problem in the latest version of the product (see below for how to obtain a
copy) or, for feature requests, if it's not present in the latest version and
you still believe we should implement it, please visit the URL of this bug
(given at the top of this mail) and add a comment to that effect, giving more
reproduction information if you have it.

If it is not a problem any longer, you need take no action. If this bug is not
changed in any way in the next two weeks, it will be automatically resolved.
Thank you for your help in this matter.

The latest beta releases can be obtained from:
Firefox:     http://www.mozilla.org/projects/firefox/
Thunderbird: http://www.mozilla.org/products/thunderbird/releases/1.5beta1.html
Seamonkey:   http://www.mozilla.org/projects/seamonkey/

Comment 3

[Peter Niemayer]

Guys, you're pathetic, seriously.

It seems the more detailed and obvious a bug is that has been reported in
Mozilla, the less likely it is solved.

I've long given up reporting Mozilla bugs, as exactly NONE of the bugs I
reported have really been fixed. The whole printing system is still a pile of
mess, not even the "scale to fit page" functions works as expected.

Instead of working on severe issues that have been pertinent in the code base
for years (such as mails being declared as "undecryptable" though they are shown
perfectly just below) colorful play-things are added on a weekly basis.

It's so sad.

Have a nice life.

Comment 4

[Kenneth Herron]

This bug is obsolete. The code in question has been removed from mozilla.

Comment 5

[Peter Niemayer]

Yeah, congratulations, let's celebrate.

Oh wait, while this broken piece of code might have gone, the whole printing system is still a huge mess. See e.g. https://bugzilla.mozilla.org/show_bug.cgi?id=191099#c24

Just let's wait until 2012, then that code might have been removed as well, or maybe the last Mozilla/Firefox user has just died out by then.