1571389 - Activating the Save To Pocket button when not yet logged into Pocket gives no audible feedback, and keyboard focus doesn't move to the signup/login popup

Status: RESOLVED FIXED

(Firefox :: Menus, enhancement)

Description

[Marco Zehe (:MarcoZ)]

STR:

1. Make sure your profile is not yet signed into Pocket.
2. Find a page you want to save to Pocket.
3. Press CTRL+L, then tab to focus the buttons to the right of the address field, then RightArrow onto the Save to Pocket button.
4. Press SpaceBar or Enter.
5. The panel visually opens that asks you to sign up or log into Pocket.
   • Expected: Keyboard focus should move there to allow a keyboard user to interact with the controls, e. g. activate the link that is appropriate.
   • Actual: Keyboard focus stays where it is. In addition, if using a screen reader, no audible clue is given that the popup even opened.
6. With the focus still on the button, press F6.
   • Expected: Since focus is on the button, the next F6 stop should be the popup.
   • Actual: F6 moves to the document. One has to press Shift+F6 to actually set focus to the popup.
7. Alternative to step 6, press Shift+F6.
   • Result: Focus also moves to the document, like with F6, and one has to press Shift+F6 a second time to get to the popup.

Suggested course of action: Since this is a case where the panel is definitely the next thing the user will want to interact with, keyboard focus should move there automatically. A keyboard user has to press F6, then Shift+F6, or Shift+F6 twice to get to the Pocket popup to interact with the links. These are two extra keystrokes that should not be necessary. Setting focus to the panel automatically an allowing to interact with the document directly also has the added benefit that screen readers will pick up the fact that a panel they want to interact with, just opened.

Comment 1

[James Teh [:Jamie]]

This needs to be fixed in browser-pageActions. This probably belongs in a different Bugzilla component, but I'm not exactly sure which one. Nevertheless, I have a patch.

Comment 2

[James Teh [:Jamie]]

Attachment: Bug 1571389: For page actions which show an iframe, focus the iframe when the action is activated.

This includes the Save to Pocket action.
Without this, keyboard users have to press f6 twice to focus the iframe.
Worse, screen reader users won't be aware anything popped up at all.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/96e453630656
For page actions which show an iframe, focus the iframe when the action is activated. r=jaws

Comment 4

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/96e453630656