Closed Bug 1571390 Opened 5 years ago Closed 5 years ago

Add BlocksRingBuffer::GetState() to take a snapshot of the state

Categories

(Core :: Gecko Profiler, task, P2)

task

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: mozbugz, Assigned: mozbugz)

References

Details

Attachments

(1 file)

Make it easier to grab all BlocksRingBuffer state variables:

  • Range start and end.
  • Number of pushed blocks/entries, number of cleared blocks/entries.

The function is thread-safe, and the returned values are consistent with each other, but they may become stale straight after the function returns (and the lock is released).
They are still valuable to statistics, and to know how far the range has at least reached (but may go further soon).

This makes it easier to grab all BlocksRingBuffer state variables:

  • Range start and end.
  • Number of pushed blocks/entries, number of cleared blocks/entries.

The function is thread-safe, and the returned values are consistent with each
other, but they may become stale straight after the function returns (and the
lock is released).
They are still valuable to statistics, and to know how far the range has at
least reached (but may go further soon).

Depends on D40620

Pushed by gsquelart@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cdc5694c40a4
BlocksRingBuffer::GetState() takes a snapshot of the current state - r=gregtatum
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: