1571405 - Remove the recently added "Active connection not found" assertion

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect, P2)

Description

[Honza Bambas (:mayhemer)]

Intro in 1565242.

Managed to trigger this in a debug build with some Ctrl-F5 hits. Connection assigned entry was existing, but there were no ^anon entry existing. And I think there could be a case there are both but both empty (just cleared with some "close persistent connections" or similar code).

To fix the original bug it's sufficient to just remove the connection from the ^anon entry. Not being able to find it is fine as it should not be anywhere else. If coalescing can somehow screw this up it's out of scope of these bugs and can't be caught by this assertion anyway.

Comment 1

[BugBot [:suhaib / :marco]]

Bugbug thinks this bug is a defect, but please change it back in case of error.

Comment 2

[Honza Bambas (:mayhemer)]

Attachment: Bug 1571405 - Remove "Active connection not found" assertion from nsHttpConnectionMgr::OnMsgReclaimConnection for being too excessive, r=kershaw

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f59b7693d943
Remove "Active connection not found" assertion from nsHttpConnectionMgr::OnMsgReclaimConnection for being too excessive, r=kershaw

Comment 4

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/f59b7693d943

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for Beta approval when you get a chance.

Comment 6

[Honza Bambas (:mayhemer)]

Comment on attachment 9083003 [details]
Bug 1571405 - Remove "Active connection not found" assertion from nsHttpConnectionMgr::OnMsgReclaimConnection for being too excessive, r=kershaw

Beta/Release Uplift Approval Request

• User impact if declined: Only affects debug builds (no test we run on m-c ever hit this, tho), functionality is unaffected, except the log (which we may want to have in parity with m-c).
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): :)
• String changes made/needed:

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9083003 [details]
Bug 1571405 - Remove "Active connection not found" assertion from nsHttpConnectionMgr::OnMsgReclaimConnection for being too excessive, r=kershaw

Minor cleanup. Approved for 69.0b14.

Comment 8

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/releases/mozilla-beta/rev/df3d499f02e8