Open Bug 1571411 Opened 3 months ago Updated 9 days ago

Initial test validity dashboard

Categories

(Tree Management :: Perfherder, task, P1)

Tracking

(Not tracked)

ASSIGNED

People

(Reporter: igoldan, Assigned: airimovici)

References

(Depends on 2 open bugs, Blocks 4 open bugs)

Details

Attachments

(1 file)

Provide a new Perfherder view to display:

  • Test name
  • Platform
  • Branch
  • Tier
  • Number of alerts

Would the performance_data.PerformanceSignatureViewSet viewset suit well for this?
The Tier & Number of alerts fields could be appended to the list of results.

I see this uses the old signature_hash, which we should also deprecate.

Flags: needinfo?(sclements)

Note: there's no direct connection between a tier & a performance signature.
Every Treeherder job has a tier directly associated to it. This means that we cannot
state the precise tier a perf signature has, rather its latest tier.

Are you ok with this, Dave?

Flags: needinfo?(dave.hunt)

(In reply to Ionuț Goldan [:igoldan], Performance Sheriff from comment #1)

Would the performance_data.PerformanceSignatureViewSet viewset suit well for this?
The Tier & Number of alerts fields could be appended to the list of results.

I see this uses the old signature_hash, which we should also deprecate.

Yes, if you don't need the performance datum for each signature then this API should be fine. However, there's a method that the serializer for PerformanceSummary API uses that would be worth moving into a separate class and using in the PerformanceSignature. It replaces the need for custom UI code (used by PerfSeriesModel.getSeriesList) that creates a name from the test suite and extra options. It'd be worth removing this UI code and letting the serializer perform this action. Doesn't need to be in this pr but I thought it'd be worth mentioning if you have the time and inclination (I can also file a bug). We then probably wouldn't need to return as many fields in the API (since some are only used in the UI to create the name).

Flags: needinfo?(sclements)

(In reply to Ionuț Goldan [:igoldan], Performance Sheriff from comment #2)

Note: there's no direct connection between a tier & a performance signature.
Every Treeherder job has a tier directly associated to it. This means that we cannot
state the precise tier a perf signature has, rather its latest tier.

Are you ok with this, Dave?

I think this is fine.

Flags: needinfo?(dave.hunt)
Priority: -- → P2
Priority: P2 → P3
Assignee: nobody → airimovici
Status: NEW → ASSIGNED
Priority: P3 → P1
You need to log in before you can comment on or make changes to this bug.