1571425 - The "Sync Options" notification is wrongly re-displayed after page refresh, even if it was manually dismissed by the user

Status: VERIFIED FIXED

(Firefox :: about:logins, defect, P3)

Description

[Cosmin Muntean [:cmuntean], Ecosystem QA]

Attachment: avatar.gif

[Affected Versions]:

• Nightly 70.0a1

[Affected Platforms]

• All Windows
• All Mac
• All Linux

[Prerequisites]

• Have a Firefox profile where you are logged into a valid FxA account.
• Have the "Logins" option from "about:preferences#sync" unchecked.

[Steps to reproduce]:

1. Open the latest Nightly browser with the profile from prerequisites.
2. Navigate to "about:logins" page.
3. Click the "X" button from the "Sync Options" notification.
4. Refresh the page and observe the behavior.

[Expected results]:

• The "Sync Options" notification is no longer displayed.

[Actual results]:

• The "Sync Options" notification is re-displayed.

[Notes]:

• Attached a screen recording with the issue.

Comment 1

[Cosmin Muntean [:cmuntean], Ecosystem QA]

Attachment: sync options.gif

Added the right screen recording of the issue.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

I'll add another button to the notification bar that will say "Don’t ask me again"

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1571425 - Add a 'Don't ask again' button to the Sync Options notification bar in about:logins. r?sfoster

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f94bd5f33670
Add a 'Don't ask again' button to the Sync Options notification bar in about:logins. r=sfoster,fluent-reviewers,flod

Comment 5

[Oana Pop-Rus]

Backed out 2 changesets (bug 1571425, bug 1584524) for bc perma failures in browser_noLoginsView.js

Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&duplicate_jobs=visible&resultStatus=success%2Csuperseded%2Ctestfailed%2Cbusted%2Cexception%2Crunnable&searchStr=os%2Cx%2C10.14%2Cdebug%2Cmochitests%2Ctest-macosx1014-64%2Fdebug-mochitest-browser-chrome-e10s-3%2Cm%28bc3%29&fromchange=3d7b77564cb7ca0800deedbb46de66a8b630d1f6&tochange=cdd02235e1cad3984bab1112c22a2771b2119608&selectedJob=272645996

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=272645996&repo=autoland&lineNumber=4184

Backout: https://hg.mozilla.org/integration/autoland/rev/12c55d177a9ff5bed2ea1a049cbf794905267823

Comment 6

[Sam Foster [:sfoster] (he/him)]

I think its the part for bug 1584524 which has tripped this osx test. I've got a try run on there with a fix which I'll re-land if all goes well.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/806f2e4f4654
Add a 'Don't ask again' button to the Sync Options notification bar in about:logins. r=fluent-reviewers,flod

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/806f2e4f4654

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

Since the status are different for nightly and release, what's the status for beta?
For more information, please visit auto_nag documentation.

Comment 10

[Simona Rosu [:srosu], Ecosystem QA]

I have verified this issue on the latest Nightly 72.0a1 (Build ID: 20191028094851) on Windows 10 x64, Mac 10.14, Ubuntu 16.04 x64.

• The “Don’t ask me again” button is added to the “Sync Options” notification.
• The “Sync Options” notification is not re-displayed after click on the “Don’t ask me again” button.