1571441 - The Special Monitor Snippet is not resized correctly when the browser window is resized

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Ciprian Muresan [:cmuresan], Ecosystem QA]

Attachment: special monitor snipper not resized correctly 2.gif

[Affected versions]:

• Firefox Nightly 70.0a1, Build ID 20190805095413

[Affected Platforms]:

• All Windows
• All Mac
• All Linux

[Prerequisites]:

• Have the browser.newtabpage.activity-stream.asrouter.devtoolsEnabled pref set to true.

[Steps to reproduce]:

1. Start the browser with a new clean profile.
2. Open a new tab and trigger the Special Monitor snippet.
3. Resize the Browser window to half screen and observe the snippet.
4. Resize the Browser to the minimum width and observe the snippet.

[Expected results]:

• Step 3: The "x" button is displayed outside of the snippet area.
• Step 4: Most of the message is displayed outside of the snippet area.

[Actual results]:

• Step 3 & 4: The snippet is resized accordingly.

[Notes]:

• The issue is also reproducible with Discovery Stream on. But in this case the Snippet should not be resized as the whole page does not support any other browser size.
• Attached a screen recording of the issue.

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/5227

Comment 2

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/a28a338396c3

Comment 3

[Marius Coman [:mcoman], Ecosystem QA]

This issue is partially fixed, now the message is correctly displayed inside the snippet's area, but the "x" button is still displayed outside of it. Also, the snippet's icon is no longer displayed after resize.

Considering the above I am reopening this issue.

Tested with the latest Firefox Nightly (70.0a1 Build ID - 20190809095611) installed, on Windows 10 x64, Arch Linux and Mac 10.14.5.

Comment 4

[Emily McMinn :emcminn]

This should be resolved by this follow-up bug now, please let me know if anything else comes up!

Comment 5

[Ed Lee :Mardak]

We'll track the additional work in bug 1572463

Comment 6

[Ed Lee :Mardak]

https://hg.mozilla.org/releases/mozilla-beta/rev/194b831613666fa13fb024c934197ee3e776e368

Comment 7

[Ciprian Muresan [:cmuresan], Ecosystem QA]

I have verified that the issue is no longer reproducible on the latest Firefox Release 69, Beta 70.0b4, and Nightly 71.0a1 on Windows 10, macOS 10.14, and Arch Linux 14.4.3.