1571492 - apilint api_changes error offer no help

Status: RESOLVED FIXED

(GeckoView :: General, defect, P3)

Description

[[ex-Mozilla] Agi Sferro | :agi]

An api error from apilint is not very helpful:

/Users/asferro/workspace/mozilla-central/mobile/android/geckoview/src/main/java/org/mozilla/geckoview/RuntimeSettings.java
  37:28  error  Unexpected api change  api_changes (android-api-lint)

cfr the old error:

> Task :geckoview:apiDiffWithGeckoBinariesDebug
--- Existing API
+++ Local API
@@ -988,11 +988,11 @@
     ctor protected RuntimeSettings(@Nullable RuntimeSettings);
     method @AnyThread public void readFromParcel(@NonNull Parcel);
     method @AnyThread protected void updatePrefs(@NonNull RuntimeSettings);
   }
 
-  public abstract static class RuntimeSettings.Builder<Settings extends org.mozilla.geckoview.RuntimeSettings> {
+  public abstract static class RuntimeSettings.Builder<Settings extends RuntimeSettings> {
     ctor public Builder();
     method @AnyThread @NonNull public Settings build();
     method @AnyThread @NonNull protected Settings getSettings();
     method @AnyThread @NonNull protected abstract Settings newSettings(@Nullable Settings);
   }

> Task :geckoview:apiLintHelpWithGeckoBinariesDebug

The API has been modified. If the changes look correct, please run

$ ./gradlew apiUpdateFileWithGeckoBinariesDebug

to update the API file.

Comment 1

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1571492 - Add apiLint command in api_changes lint errors.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/90128608235b
Add apiLint command in api_changes lint errors. r=nalexander

Comment 3

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/90128608235b

Comment 4

[Chris Peterson [:cpeterson]]

firefox69=wontfix because we don't need to uplift aiplint fixes to Beta.