1571630 - Remove WebConsoleUI setSaveRequestAndResponseBodies

Status: ASSIGNED

(DevTools :: Console, task, P2)

Description

[Nicolas Chevobbe [:nchevobbe]]

The function is used to disable saving network calls response bodies for the browser console, claiming that it's not possible to display the response in the browser console.
But this is false, we do show requests like in the webconsole and you can expand them to inspect the response.

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Honza, should we remove the "devtools.netmonitor.saveRequestAndResponseBodies" pref as well? It's only used from the console https://searchfox.org/mozilla-central/search?q=devtools.netmonitor.saveRequestAndResponseBodies&case=true&path=

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Yes, I think we should remove it. I tested this and I see no reason to keep the pref.

Honza

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1571630 - Remove WebConsoleUI setSaveRequestAndResponseBodies. r=Honza.

We were assuming that the BrowserConsole couldn't display a Response
body for a given network call, but we actually can.
This is probably an old limitation we don't have anymore, so we can
remove the setSaveRequestAndResponseBodies and the associated piece
of code on the WebConsole actor.
We take this as an opportunity to remove the devtools.netmonitor.saveRequestAndResponseBodies
preference, that was only checked in the webconsole.