Open Bug 1571645 Opened 2 years ago Updated 2 years ago

TB 60.8.0: TypeError: aDragSession.sourceNode is null AND TypeError: this.chromeUtilsWindow.openUILinkIn is not a function

Categories

(Thunderbird :: Mail Window Front End, defect)

defect
Not set
normal

Tracking

(Not tracked)

People

(Reporter: ishikawa, Unassigned)

Details

Attachments

(1 file)

(Strange. I tried to post a comment, but forgot to set "Type" and "Component" fields. Bugzilla warned me, but somehow the comment part became empty (!?). So I am retyping again. Grrr...

While using TB (32-bit) under Windows 10,
I noticed the following error.
TypeError: aDragSession.sourceNode is null

The code is here: in omini.ja (?),
chrome/messenger/content/messenger/content/messenger/messageWindow.js

canDrop: function(aEvent, aDragSession) //allow drop from mail:3pane window only - 4xp
{
var doc = aDragSession.sourceNode.ownerDocument; <=== HERE
var elem = doc.getElementById("messengerWindow");
return (elem && (elem.getAttribute("windowtype") == "mail:3pane"));
},

So during runtime, sourceNode can be null. We should add the check and if it is null, return false immediately.

What suprised me is though another bug.
When I clicked on the [detail(s)] link of the error message, I got another error.
I am using a Japanese version of TB and so the line actually looks like this. (Attachment is the screen capture.)
TypeError: aDragSession.sourceNode is null [詳細]

I get the following error when I clicked on [詳細] above.

TypeError: this.chromeUtilsWindow.openUILinkIn is not a function[詳細]

If I click on the [詳細] link on this line, only the count of the error increases.

The code is here.
/**

  • Open a link in a new tab.
  • @param string link
  •    The URL you want to open in a new tab.
    

*/
openLink(link, e) {
let isOSX = Services.appinfo.OS == "Darwin";
if (e && (e.button === 1 || (e.button === 0 && (isOSX ? e.metaKey : e.ctrlKey)))) {
this.chromeUtilsWindow.openUILinkIn(link, "tabshifted");
} else {
this.chromeUtilsWindow.openUILinkIn(link, "tab"); <===
}
},

I could get to the file and the line by using the link on the right most position of the error message.
So something is WRONG SOMEWHERE.

TB is 60.8.0 (32-bit).

Can you try TB 69 beta? I don't think we'll work on 60 any more.

(In reply to ISHIKAWA, Chiaki from comment #0)

(Strange. I tried to post a comment, but forgot to set "Type" and "Component" fields. Bugzilla warned me, but somehow the comment part became empty (!?). So I am retyping again. Grrr...

Please file a bug against BMO :)
and CC me https://bugzilla.mozilla.org/enter_bug.cgi?product=bugzilla.mozilla.org

Component: Untriaged → Mail Window Front End

(In reply to Jorg K (GMT+2) from comment #2)

Can you try TB 69 beta? I don't think we'll work on 60 any more.

Will do hopefully next week while I am taking days off from my day job.

TIA

You need to log in before you can comment on or make changes to this bug.