1571685 - The "Dismiss" button from the "Special Monitor" snippet is not visible if the system's "High Contrast" mode is enabled

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P3)

Description

[Marius Coman [:mcoman], Ecosystem QA]

Attachment: rec of the issue.gif

[Affected versions]:

• Firefox Release 68.0.1 - Build ID: 20190717172542
• Firefox Beta 69.0b10 - Build ID: 20190801185445
• Firefox Nightly 70.0a1 - Build ID: 20190805220030

[Affected Platforms]:

• All Windows

[Prerequisites]:

• Have a new Firefox profile with the "browser.newtabpage.activity-stream.asrouter.devtoolsEnabled" pref's value set to "true" in the "about:config" page;
• Have the "High Contrast" mode enabled.

[Steps to reproduce]:

1. Open the browser with the profile from prerequisites.
2. Navigate to "about:newtab#asrouter" and select the "snippets_local_testing" option from the "Messages" dropdown menu.
3. Scroll to the bottom of the page and click the "Show" button from the "SPECIAL_SNIPPET_BUTTON_1" section.
4. Click the "Collapse devtools" button from the top-right part of the page.
5. Observe the "Special Monitor" snippet's elements.

[Expected result]:

• All the snippet's elements are correctly rendered and visible.

[Actual result]:

• The "Dismiss" button is not visible at all.

[Notes]:

• This issue is reproducible with all the snippets.
• Attached a screen recording of the issue.

Comment 1

[Kate Hudson :k88hudson]

Setting this to p2 since this is an existing issue and not a regression caused by the new feature

Comment 2

[Jim T]

Sounds like we aren't able to detect high-contrast mode. We might get some recommendations from the accessibility team on that.

Comment 3

[Emily McMinn :emcminn]

Attachment: Bug 1571685 - Set fill color and inheritance on Snippet block button to be compatible with Windows High Contrast mode

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7ea1586e531e
Set fill color and inheritance on Snippet block button to be compatible with Windows High Contrast mode r=Gijs

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/7ea1586e531e

Comment 6

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Nightly (79.0a1 Build ID - 20200622093309) installed, on Windows 10 x64. Now, the "Dismiss" button from the "Special Monitor" snippet is visible if the system's "High Contrast" mode is enabled.