1571875 - Update DynamicallyLinkedFunctionPtr to take advantage of new MOZ_STATIC_LOCAL_CLASS annotation

Status: RESOLVED FIXED

(Core :: mozglue, task, P1)

Description

[(No longer employed by Mozilla) Aaron Klotz]

Most uses of DynamicallyLinkedFunctionPtr are as static locals, which means that we end up generating a bunch of unnecessary FreeLibrary calls when these objects are destroyed at shutdown.

Now that we have MOZ_STATIC_LOCAL_CLASS, we can create a variant for static locals that has a trivial destructor, thus eliminating all that FreeLibrary goop.

Comment 1

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Bug 1571875: Part 1 - Refactor DynamicallyLinkedFunctionPtr into static local and normal variants; r=mhowell!

This patch does two things:

1. We refactor the resolution of function pointer and return type so that we
   may support additional calling conventions besides just __stdcall;

2. We refactor DynamicallyLinkedFunctionPtr into a base class, and create
   StaticDynamicallyLinkedFunctionPtr to specifically handle the static local
   use case.

Comment 2

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Bug 1571875: Part 2 - Change over all existing static local uses of DynamicallyLinkedFunctionPtr to use StaticDynamicallyLinkedFunctionPtr instead; r=mhowell!

Depends on D40885

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f1c97ef1f9cb
Part 1 - Refactor DynamicallyLinkedFunctionPtr into static local and normal variants; r=mhowell
https://hg.mozilla.org/integration/autoland/rev/20cdaeefd4e1
Part 2 - Change over all existing static local uses of DynamicallyLinkedFunctionPtr to use StaticDynamicallyLinkedFunctionPtr instead; r=mhowell

Comment 4

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/f1c97ef1f9cb
https://hg.mozilla.org/mozilla-central/rev/20cdaeefd4e1