1571899 - Identify and apply formatter to java code

Status: RESOLVED FIXED

(GeckoView :: General, task, P3)

Description

[[ex-Mozilla] Agi Sferro | :agi]

Similarly to what happend to our javascript and c++ we should identify a formatter and apply it to the entire java codebase. And make sure it runs on every check in.

Comment 1

[[ex-Mozilla] Agi Sferro | :agi]

snorp linked to this plugin which seems promising: https://github.com/diffplug/spotless (with the google-java-format)

Comment 2

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1571899 - Format Java codebase with google-java-formatter.

Comment 3

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1571899 - Use google-java-format via spotless to enforce Java formatting.

This change adds a new lint android-format which enforces formatting of Java
code using google-java-format.

To run the lint simply run:

./mach lint -l android-format

This command also support automatically fixing all errors running by adding
--fix:

./mach lint -l android-format --fix

This change also removes all the formatting-related checkstyle checks which are
now implicitly enforced by the formatter.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a0a60d0f61a5
Use google-java-format via spotless to enforce Java formatting. r=ahal,owlish
https://hg.mozilla.org/integration/autoland/rev/1fa64c7fe170
Format Java codebase with google-java-formatter. r=owlish

Comment 5

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/a0a60d0f61a5
https://hg.mozilla.org/mozilla-central/rev/1fa64c7fe170