1571942 - Pick element keyboard shortcut focuses the devtools window if the inspector tool was not selected

Status: RESOLVED FIXED

(DevTools :: Inspector, defect, P2)

Description

[Daisuke Akatsuka (:daisuke)]

This is a follow up for a report from Julian in bug 149187:

https://phabricator.services.mozilla.com/D40378#inline-247342

Note that this is only called when the inspector is already the selected tool.
For the STRs:

open devtools in window host
select webconsole
focus content page
trigger inspector shortcut

, the devtools window will still be focused.

I also could reproduce it. However, I'm not sure this behavior is bad or not. So, we need to decide the behavior first, then let's fix this if needed.

Comment 1

[Patrick Brosset <:pbro>]

This was fixed recently if you are in the inspector, but it's still a problem if you are in another tool as the STR say.
So let's fix this. Moving this to be a defect.

Comment 2

[Daisuke Akatsuka (:daisuke)]

I'm sorry, the bug number which I reported was wrong.
The correct is bug 1491874.

Comment 3

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1571942: Avoid to raise the toolbox whenever the shortcut key of inspector was typed. r?jdescottes!

Comment 4

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1571942: Add a test for inspector shortcut in case that other tool is selected. r?jdescottes!

Depends on D44772

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7babba8a17f6
Avoid to raise the toolbox whenever the shortcut key of inspector was typed. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/1970fc59ee5f
Add a test for inspector shortcut in case that other tool is selected. r=jdescottes

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/7babba8a17f6
https://hg.mozilla.org/mozilla-central/rev/1970fc59ee5f