Closed Bug 1571977 Opened 2 years ago Closed 2 years ago

[wr-intro] Add wrench test for textureRect

Categories

(Core :: Graphics: WebRender, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla71
Tracking Status
firefox71 --- fixed

People

(Reporter: gw, Assigned: ktaeleman)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

We currently don't have any automated wrench tests for the textureRect sampler type. Adding this would allow us to detect regressions here before running the full Gecko test suite.

Context: https://github.com/servo/webrender/issues/2557

Blocks: wr-intro
Priority: -- → P3
Assignee: nobody → ktaeleman
Pushed by gwatson@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bde7561bd171
Add wrench test for textureRect. r=gw

Backed out changeset bde7561bd171 (Bug 1571977) for wrench amd tidy failures

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&fromchange=bde7561bd1714212f4d97b82270d2361a988ab85&tochange=e4fdcdf5ea3fa2cb9cba52193691de1863bf0422&selectedJob=265835618

Backout link: https://hg.mozilla.org/integration/autoland/rev/e4fdcdf5ea3fa2cb9cba52193691de1863bf0422

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=265835618&repo=autoland&lineNumber=2748

[task 2019-09-10T01:12:50.886Z] ../target/debug/build/osmesa-src-5b5fac236d7f24a4/out/lib/gallium
[task 2019-09-10T01:12:50.886Z] Running: ../target/debug/wrench --no-scissor -h reftest
[task 2019-09-10T01:12:50.886Z] Traceback (most recent call last):
[task 2019-09-10T01:12:50.886Z] File "script/headless.py", line 131, in <module>
[task 2019-09-10T01:12:50.886Z] subprocess.check_call(cmd)
[task 2019-09-10T01:12:50.887Z] File "/usr/lib/python2.7/subprocess.py", line 186, in check_call
[task 2019-09-10T01:12:50.887Z] raise CalledProcessError(retcode, cmd)
[task 2019-09-10T01:12:50.887Z] subprocess.CalledProcessError: Command '['../target/debug/wrench', '--no-scissor', '-h', 'reftest']' returned non-zero exit status -6
[fetches 2019-09-10T01:12:50.889Z] removing /builds/worker/fetches
[fetches 2019-09-10T01:12:51.014Z] finished
[taskcluster 2019-09-10 01:12:51.332Z] === Task Finished ===
[taskcluster 2019-09-10 01:12:51.332Z] Unsuccessful task run with exit code: 1 completed in 609.74 seconds

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=265835587&repo=autoland&lineNumber=7503

[task 2019-09-10T01:10:40.731Z] ../target/release/build/osmesa-src-ac01c37ffe6dcf3f/out/lib/gallium
[task 2019-09-10T01:10:40.731Z] Running: ../target/release/wrench --no-scissor -h reftest
[task 2019-09-10T01:10:40.731Z] Traceback (most recent call last):
[task 2019-09-10T01:10:40.731Z] File "script/headless.py", line 131, in <module>
[task 2019-09-10T01:10:40.731Z] subprocess.check_call(cmd)
[task 2019-09-10T01:10:40.731Z] File "/usr/lib/python2.7/subprocess.py", line 186, in check_call
[task 2019-09-10T01:10:40.731Z] raise CalledProcessError(retcode, cmd)
[task 2019-09-10T01:10:40.731Z] subprocess.CalledProcessError: Command '['../target/release/wrench', '--no-scissor', '-h', 'reftest']' returned non-zero exit status -6
[fetches 2019-09-10T01:10:40.734Z] removing /builds/worker/fetches
[fetches 2019-09-10T01:10:40.867Z] finished
[taskcluster 2019-09-10 01:10:41.359Z] === Task Finished ===
[taskcluster 2019-09-10 01:10:41.359Z] Unsuccessful task run with exit code: 1 completed in 524.864 seconds

https://treeherder.mozilla.org/logviewer.html#?job_id=265835592&repo=autoland

[task 2019-09-10T01:05:26.671Z] Progress: 14% (142/987)
[task 2019-09-10T01:05:26.676Z] Progress: 14% (143/987)
[task 2019-09-10T01:05:26.681Z] Progress: 14% (144/987)
[task 2019-09-10T01:05:26.682Z] Progress: 14% (145/987)
[task 2019-09-10T01:05:26.682Z] ./wrench/src/yaml_frame_reader.rs:143: Line is longer than 120 characters
[task 2019-09-10T01:05:26.699Z]
[task 2019-09-10T01:05:26.699Z] ./wrench/src/yaml_frame_reader.rs:110: found an empty line following a {
[task 2019-09-10T01:05:26.754Z]
[task 2019-09-10T01:05:26.754Z] ./wrench/src/yaml_frame_reader.rs:749: else braces should be on the same line
[task 2019-09-10T01:05:26.869Z]
[task 2019-09-10T01:05:27.008Z] Progress: 14% (146/987)
[task 2019-09-10T01:05:27.090Z] Progress: 14% (147/987)
[task 2019-09-10T01:05:27.101Z] Progress: 14% (148/987)
[task 2019-09-10T01:05:27.126Z] Progress: 15% (149/987)
[task 2019-09-10T01:05:27.146Z] Progress: 15% (150/987
...

Flags: needinfo?(ktaeleman)
Pushed by gwatson@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fea9b09a9f47
Add wrench test for textureRect. r=gw
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
Flags: needinfo?(ktaeleman)
You need to log in before you can comment on or make changes to this bug.