Closed Bug 1572037 Opened 5 years ago Closed 5 years ago

Nothing happens if the "Cancel" button of the "Create New Logins" mode is clicked if there are no saved logins in the list

Categories

(Firefox :: about:logins, defect, P2)

Desktop
All
defect

Tracking

()

RESOLVED DUPLICATE of bug 1576735
Tracking Status
firefox70 --- affected

People

(Reporter: srosu, Assigned: jaws)

References

Details

(Whiteboard: [passwords:management] [skyline])

Attachments

(1 file, 1 obsolete file)

Attached video Cancel_button.mp4

[Affected versions]:

  • Firefox latest Nightly 70.0a1 (2019-08-06) (64-bit)

[Affected Platforms]:

  • Mac 10.14
  • Windows 10 x64
  • Ubuntu 18.04 x64

[Prerequisites]:

  • Have a new Firefox profile with no saved logins.

[Steps to reproduce]:

  1. Open the browser and navigate to the "about:logins" page.
  2. Click on the “Create New Login” button.
  3. Leave all fields empty.
  4. Click on the “Cancel” button.

[Expected result]:

  • The “Create New Login” mode is dismissed.

[Actual result]:

  • Nothing happens.

[Notes]:

  • This issue is also reproducible when the “Create New Login” mode is completed and click on the “Discard” button.
  • Attached a screen recording with the issue.
Priority: -- → P2
Flags: qe-verify+

Ryan, do you know what should happen in this case?

Flags: needinfo?(rgaddis)

I agree with Simona; the “Create New Login” set of fields should be dismissed in this case.

Flags: needinfo?(rgaddis)
Assignee: nobody → ntim.bugs

Prioritizing the design spec bugs first.

Assignee: ntim.bugs → nobody
Assignee: nobody → jaws
Status: NEW → ASSIGNED

Since we don't track what login was selected prior to entering the create view, it seemed simplest to reset the filter upon canceling when logins are stored. This has the effect of selecting the first login in the list.

Comment on attachment 9088312 [details]
Bug 1572037 - Canceling the create login form when no logins are in the list should revert to the previous view. r?MattN

Revision D43544 was moved to bug 1576735. Setting attachment 9088312 [details] to obsolete.

Attachment #9088312 - Attachment is obsolete: true

I didn't intend to land the fix with the newer bug but that's what happened, so I'm duping this bug forward to bug 1576735.

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → DUPLICATE
Flags: qe-verify+
Component: Password Manager → about:logins
Product: Toolkit → Firefox
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: