Closed Bug 1572052 Opened 4 months ago Closed 3 months ago

Disable “Create New Login” button when creating a new login

Categories

(Firefox :: about:logins, defect, P2)

Desktop
All
defect

Tracking

()

VERIFIED FIXED
Firefox 70
Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 --- unaffected
firefox68 --- unaffected
firefox69 --- disabled
firefox70 --- verified

People

(Reporter: simona.rosu, Assigned: ntim)

References

Details

(Whiteboard: [passwords:management] [skyline])

Attachments

(2 files)

[Affected versions]:

  • Firefox latest Nightly 70.0a1 (2019-08-06) (64-bit)

[Affected Platforms]:

  • Mac 10.14
  • Windows 10 x64
  • Ubuntu 18.04 x64

[Steps to reproduce]:

  1. Open the Firefox browser and navigate to the "about:logins" page.
  2. Click on the “Create New Login” button.
  3. Fill in any field.
  4. Click on the “Create New Login” button.

[Expected result]:

  • Nothing happens, the “Create New Login” button is inactive.

[Actual result]:

  • The "Create New Login" button is active and the “Create New Login” modal is opened.

[Notes]:

  • This issue is also reproducible when editing a login.
  • In the current behavior if the fields are completed, when clicking the “Create New Login” button, the “Discard Unsaved Changes” pop-up is not displayed and the completed data will be lost.
  • The "Create New Login" button from the about:logins page should not be active when creating/editing a login, as shown in https://mozilla.invisionapp.com/share/EJRHBMEDKF8#/screens/372727457
  • Attached a screen recorder with the issue.
Whiteboard: [passwords:management] [skyline]
Assignee: nobody → ntim.bugs
Status: NEW → ASSIGNED
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/2faaf4394770
Disable “Create New Login” button when creating a new login. r=MattN
Summary: The “Create New Login” button from “about:logins” page is active when creating/editing a login → Disable “Create New Login” button when creating a new login
Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6a5b28ffb92e
Fix eslint failures on browser_createLogin.js.
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70

I have verified this issue on the latest Nightly 70.0a1 build (2019-08-14) (64 bit) on Windows 10 x64, Windows 7 x64m Mac 10.14 and Ubuntu 18.04.

  • The “Create New Login” button is inactive when creating a new login.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
Component: Password Manager → about:logins
Product: Toolkit → Firefox
Target Milestone: mozilla70 → Firefox 70
You need to log in before you can comment on or make changes to this bug.