Closed Bug 1572056 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 18311 - Move the future back by 19 years.

Categories

(Core :: Networking: Cookies, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream][necko-triaged])

Sync web-platform-tests PR 18311 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/18311
Details from upstream follow.

Balazs Engedy <engedy@chromium.org> wrote:

Move the future back by 19 years.

The following cookie lifetime tests prophesied that 8am GMT 7th Aug 2019
would never arrive, but in hindsight this prediction turned out to be
overly pessimistic, as evidenced by the tests failing across the board:

external/wpt/cookies/http-state/comma-tests.html
external/wpt/cookies/http-state/general-tests.html
virtual/samesite-by-default-cookies/external/wpt/cookies/http-state/comma-tests.html
virtual/samesite-by-default-cookies/external/wpt/cookies/http-state/general-tests.html

This CL redefines the future as the very first second of the year 2038,
which is admittedly a couple of days earlier than when the world will
actually end, but is hopefully a good enough approximation as it seems
unlikely that in those final days it will be anybody's primary concern
that these tests are failing.

Bug: None
Change-Id: I4dcebedecb802785fbd494b864bc2cbbf8f66718
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741811
Reviewed-by: Balazs Engedy \<engedy@chromium.org>
Reviewed-by: Friedrich [CET] \<fhorschig@chromium.org>
Commit-Queue: Balazs Engedy \<engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684712}

Component: web-platform-tests → Networking: Cookies
Product: Testing → Core
The PR was not expected to affect any tests, but the try push wasn't a success. Check the try results for infrastructure issues
Whiteboard: [wptsync downstream] → [wptsync downstream][necko-triaged]
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/96bb53f90640
[wpt PR 18311] - Move the future back by 19 years., a=testonly
Result changes from PR not available.
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.