1572139 - Enable sending UI notifications for ETP on mobile

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P1)

Description

[(no longer active)]

Similar to bug 1566836, there is another pref which we currently do not enable on mobile, which causes us to not send UI notifications for ETP on mobile. This causes devtools console messages to not work on Fennec. We should just remove this (now useless pref) on trunk and turn it on for branches.

Comment 1

[(no longer active)]

Attachment: Bug 1572139 - Enable sending UI notifications for ETP on mobile;

Comment 2

[(no longer active)]

Attachment: Bug 1572139 - Enable sending UI notifications for ETP on mobile;

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f6e9a663d0ff
Enable sending UI notifications for ETP on mobile; r=baku

Comment 4

[(no longer active)]

Attachment: Bug 1572139 - Fix the assertion

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/85a61edcb280
Fix the assertion

Comment 6

[Chris Peterson [:cpeterson]]

Ehsan, do we need to uplift your ETP UI notification fix to Fennec? We plan to ship ETP in Fennec ESR 68.1 (September 3).

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/f6e9a663d0ff
https://hg.mozilla.org/mozilla-central/rev/85a61edcb280

Comment 8

[(no longer active)]

(In reply to Chris Peterson [:cpeterson] from comment #6)

Ehsan, do we need to uplift your ETP UI notification fix to Fennec? We plan to ship ETP in Fennec ESR 68.1 (September 3).

Definitely, that was why I attached a branch patch. :-)

Comment 9

[(no longer active)]

Comment on attachment 9083721 [details]
Bug 1572139 - Enable sending UI notifications for ETP on mobile;

Beta/Release Uplift Approval Request

• User impact if declined: Devtools web console messages for ETP will not work on mobile.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: STR:

1. Ensure the network.cookie.cookieBehavior pref is set to 4 on Fennec.
2. Connect devtools web console to Fennec using remote debugging.
3. Navigate to https://www.cnn.com.
4. Ensure you see messages like the below in the web console:

Request to access cookie or storage on “<url>” was blocked because it came from a tracker and content blocking is enabled.

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The code that gets enabled by this pref has been shipped to users on desktop...
• String changes made/needed: None

Comment 10

[Julien Cristau [:jcristau] (back August 18)]

Comment on attachment 9083721 [details]
Bug 1572139 - Enable sending UI notifications for ETP on mobile;

Moving the release uplift request over to esr68 where fennec lives nowadays.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9083721 [details]
Bug 1572139 - Enable sending UI notifications for ETP on mobile;

Enables UI notifications for ETP on mobile. Approved for Fennec 68.1b6. Note that only this branch patch need to land.

Comment 12

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/513c1ea45a6a

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr68/rev/cc4a2709f59e

Comment 14

[Eliza Balazs]

Hi!
I tested this on ESR 68.1b6, Beta 69.0b13, Nightly 70.0a1 (2019-08-13) with Samsung Galaxy S8 (Android 9) following the steps from Comment 9 and messages like "Request to access cookie or storage on “<url>” was blocked because it came from a tracker and content blocking is enabled." are displayed in the web console.
I will mark this as verified on Firefox esr68, Firefox 69 and Firefox 70. Thanks!