Closed Bug 1572189 Opened 4 years ago Closed 4 years ago

Add padding between sub-sections


(Firefox :: Security, task, P1)




Firefox 70
Tracking Status
firefox70 --- fixed


(Reporter: evilpie, Assigned: danielleleb12)


(Blocks 1 open bug)



(3 files)

Attached image about:certificate

Some key/value pairs are logically grouped and should be separated by some additional space. "Certainly Something" implements this.

After the pair of Policy and Value key/values there should be some additional padding.

Attached image Certainly Something

The same applies to (at least) "Embedded SCTs" and "Authority Info (AIA)".

Assignee: nobody → danielleleb12
Priority: -- → P1

Depends on D41078

Keywords: checkin-needed

Danielle, D41095 depends on some revisions that are not accepted yet: Is not Accepted. [D39530, D39531, D41078]
Also No reviewer has accepted the current diff. [D39530, D39531, D41032, D41078, D41095] Please resolve these dependencies before we can land the bug.

Flags: needinfo?(danielleleb12)
Keywords: checkin-needed

Sorry about that, I had forgotten to rebase onto central.

Flags: needinfo?(danielleleb12)
Keywords: checkin-needed

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. applying /tmp/tmpHk79nl toolkit/components/certviewer/content/components/info-item.js Hunk #1 succeeded at 28 with fuzz 2 (offset 2 lines). toolkit/components/certviewer/content/components/info-item.css Hunk #1 succeeded at 53 with fuzz 2 (offset 27 lines). 1 out of 1 hunk ignored -- saving rejects to file toolkit/components/certviewer/content/components/info-group.js.rej toolkit/components/certviewer/content/components/certificate-section.js Hunk #1 FAILED at 47. 1 out of 1 hunk FAILED -- saving rejects to file toolkit/components/certviewer/content/components/certificate-section.js.rej abort: patch command failed: exited with status 256

Flags: needinfo?(danielleleb12)
Keywords: checkin-needed
Flags: needinfo?(danielleleb12)
Keywords: checkin-needed

Pushed by
Adds padding between sub-sections. r=johannh

Keywords: checkin-needed
Backout by
Backed out 6 changesets (bug 1572189, bug 1572773, bug 1568974, bug 1571710, bug 1568972) for eslint failure on content/pageinfo/security.js. CLOSED TREE
Keywords: checkin-needed

Pushed by
Adds padding between sub-sections. r=johannh

Keywords: checkin-needed
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
You need to log in before you can comment on or make changes to this bug.