Closed Bug 1572202 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 18322 - [Native File System] Improve error reporting.

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox70 fixed)

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 18322 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/18322
Details from upstream follow.

Marijn Kruisselbrink <mek@chromium.org> wrote:

[Native File System] Improve error reporting.

Don't try to force every error into a base::File::Error, instead have our own
enum and a custom error message. This should make it easier for web developers
to debug what is going on.

Also switches some DOMException constructor usage to using V8ThrowDOMException
which results in the exception messages actually being shown in dev-tools.

Bug: 971268
Change-Id: Id5128363bf5410ed08c1f4e65ebbe4b4bee93d7a

Reviewed-on: https://chromium-review.googlesource.com/1738654
WPT-Export-Revision: aaf0251d12966e932918db4b0ab7d2e472b43320

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Ran 3 tests and 32 subtests
OK     : 3
FAIL   : 32
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cae32474972d
[wpt PR 18322] - [Native File System] Improve error reporting., a=testonly
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.