1572258 - Prevent concurrent instances of TemporaryAccessGrantObserver from being created for the same (principal, permission type) pair

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, defect)

Description

[(no longer active)]

When granting a storage access API automatic access grant, we want to ensure the access expires 24 hours after the first time it was granted in a long running session. If the third-party frame calls the storage access API multiple times within this window there isn't a good reason to create multiple observers since the ones created after the first one would be no-op unless if the timers fire between the time the first timer fires and 24 hours after access is granted again, in which case the second access will be expiring too soon.

Comment 1

[(no longer active)]

Attachment: Bug 1572258 - Prevent concurrent instances of TemporaryAccessGrantObserver from being created for the same (principal, permission type) pair;

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b7a4b4f41c3b
Prevent concurrent instances of TemporaryAccessGrantObserver from being created for the same (principal, permission type) pair; r=baku

Comment 3

[Cristina Coroiu [:ccoroiu]]

Backed out changeset b7a4b4f41c3b (Bug 1572258) for causing leaks

Backout: 4596d8646054d832e6727840908e70b4d45f9ca1

Failure push: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=260618228&revision=b7a4b4f41c3b38a011ccb22c7ccfe4cab28824a7

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=260618228&repo=autoland&lineNumber=102330

[task 2019-08-08T17:43:17.193Z] 17:43:17 INFO - TEST-INFO | leakcheck | default leaked 5 nsTimerImpl
[task 2019-08-08T17:43:17.194Z] 17:43:17 INFO - TEST-UNEXPECTED-FAIL | leakcheck | default 3656 bytes leaked (CondVar, IdlePeriod, Mutex, ThreadEventTarget, ThreadTargetSink, ...)
[task 2019-08-08T17:43:17.194Z] 17:43:17 INFO -
[task 2019-08-08T17:43:17.195Z] 17:43:17 INFO - leakcheck | Processing leak log file c:\users\task_1565279325\appdata\local\temp\tmptoigsg.mozrunner\runtests_leaks_gpu_pid3664.log
[task 2019-08-08T17:43:17.195Z] 17:43:17 INFO -
[task 2019-08-08T17:43:17.196Z] 17:43:17 INFO - == BloatView: ALL (cumulative) LEAK AND BLOAT STATISTICS, gpu process 3664
[task 2019-08-08T17:43:17.197Z] 17:43:17 INFO -
[task 2019-08-08T17:43:17.197Z] 17:43:17 INFO - |<----------------Class--------------->|<-----Bytes------>|<----Objects---->|
[task 2019-08-08T17:43:17.198Z] 17:43:17 INFO - | | Per-Inst Leaked| Total Rem|
[task 2019-08-08T17:43:17.199Z] 17:43:17 INFO - 0 |TOTAL | 30 0| 4880492 0|
[task 2019-08-08T17:43:17.199Z] 17:43:17 INFO -
[task 2019-08-08T17:43:17.200Z] 17:43:17 INFO - nsTraceRefcnt::DumpStatistics: 381 entries

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a549ac878890
Prevent concurrent instances of TemporaryAccessGrantObserver from being created for the same (principal, permission type) pair; r=baku

Comment 5

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/a549ac878890