Closed Bug 1572298 Opened 4 months ago Closed 4 months ago

Port Bug 1280216 "Remove nsIAboutModule::GetIndexedDBOriginPostfix()" to SeaMonkey

Categories

(SeaMonkey :: Security, enhancement)

enhancement
Not set

Tracking

(seamonkey2.49esr wontfix, seamonkey2.53 affected, seamonkey2.57esr fixed, seamonkey2.63 wontfix)

RESOLVED FIXED
seamonkey2.67
Tracking Status
seamonkey2.49esr --- wontfix
seamonkey2.53 --- affected
seamonkey2.57esr --- fixed
seamonkey2.63 --- wontfix

People

(Reporter: frg, Assigned: frg)

Details

Attachments

(1 file)

GetIndexedDBOriginPostfix() in suite/components/nsAbout.js is unused.

Also clean up the new channel creation a bit. Warn when no loadInfo is provided so that we can get rid of the deprecation warning:

Timestamp: 8/8/2019, 3:09:53 AM
Warning: Warning: ‘nsIAboutModule->newChannel(aURI)’ deprecated, please use ‘nsIAboutModule->newChannel(aURI, aLoadInfo)’
Source File: jar:file:///C:/Program%20Files/SeaMonkey/omni.ja!/components/FeedWriter.js
Line: 984

And aligning code with Thunderbird. They provide a codebaseprincipal for non chrome privileged content.

[Approval Request Comment]
Regression caused by (bug #): 1280216
User impact if declined: outdated code.
Testing completed (on m-c, etc.): 2.53
Risk to taking this patch (and alternatives if risky): low risk
String changes made by this patch: --

Attachment #9083879 - Flags: review?(iann_bugzilla)
Attachment #9083879 - Flags: approval-comm-release?
Attachment #9083879 - Flags: approval-comm-esr60?
Comment on attachment 9083879 [details] [diff] [review]
1572298-aboutload-253.patch

>+    // We want a happy family which is always providing a lodInfo object.
Nit: typo maybe loadInfo rather than lodInfo?

r/a=me with that fixed.
Attachment #9083879 - Flags: review?(iann_bugzilla)
Attachment #9083879 - Flags: review+
Attachment #9083879 - Flags: approval-comm-release?
Attachment #9083879 - Flags: approval-comm-release+
Attachment #9083879 - Flags: approval-comm-esr60?
Attachment #9083879 - Flags: approval-comm-esr60+

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/b249cb11d147
Port Bug 1280216 "Remove nsIAboutModule::GetIndexedDBOriginPostfix()". r=IanN

Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.