1572298 - Port Bug 1280216 "Remove nsIAboutModule::GetIndexedDBOriginPostfix()" to SeaMonkey

Status: RESOLVED FIXED

(SeaMonkey :: Security, enhancement)

Description

[Frank-Rainer Grahl (:frg)]

GetIndexedDBOriginPostfix() in suite/components/nsAbout.js is unused.

Comment 1

[Frank-Rainer Grahl (:frg)]

Attachment: 1572298-aboutload-253.patch

Also clean up the new channel creation a bit. Warn when no loadInfo is provided so that we can get rid of the deprecation warning:

Timestamp: 8/8/2019, 3:09:53 AM
Warning: Warning: ‘nsIAboutModule->newChannel(aURI)’ deprecated, please use ‘nsIAboutModule->newChannel(aURI, aLoadInfo)’
Source File: jar:file:///C:/Program%20Files/SeaMonkey/omni.ja!/components/FeedWriter.js
Line: 984

And aligning code with Thunderbird. They provide a codebaseprincipal for non chrome privileged content.

[Approval Request Comment]
Regression caused by (bug #): 1280216
User impact if declined: outdated code.
Testing completed (on m-c, etc.): 2.53
Risk to taking this patch (and alternatives if risky): low risk
String changes made by this patch: --

Comment 2

[Ian Neal]

Comment on attachment 9083879 [details] [diff] [review]
1572298-aboutload-253.patch

>+    // We want a happy family which is always providing a lodInfo object.
Nit: typo maybe loadInfo rather than lodInfo?

r/a=me with that fixed.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b249cb11d147
Port Bug 1280216 "Remove nsIAboutModule::GetIndexedDBOriginPostfix()". r=IanN

Comment 4

[Frank-Rainer Grahl (:frg)]

https://hg.mozilla.org/releases/comm-esr60/rev/70f19359835b5bb33f830cd140d0e5159a120701