1572301 - Provide correct loadinfo in SeaMonkeys feedwriter.js

Status: RESOLVED FIXED

(SeaMonkey :: Feed Discovery and Preview, enhancement)

Description

[Frank-Rainer Grahl (:frg)]

Feedwriter tries to create a channel with outdated parameters resulting in a warning. A loadInfo object should be used as a parameter.

Timestamp: 8/8/2019, 3:09:53 AM
Warning: Warning: ‘nsIAboutModule->newChannel(aURI)’ deprecated, please use ‘nsIAboutModule->newChannel(aURI, aLoadInfo)’
Source File: jar:file:///C:/Program%20Files/SeaMonkey/omni.ja!/components/FeedWriter.js
Line: 984

Comment 1

[Frank-Rainer Grahl (:frg)]

Attachment: 1572301-feedschannel-253.patch

Fir fixing this it needs parts from:

Bug 1116278 Make JS callers of ios.newChannel call ios.newChannel2 in browser/components/feeds (r=neil)
https://hg.mozilla.org/mozilla-central/rev/f15991d2f3b3

Bug 1263496 Create null principal with correct origin attributes
https://hg.mozilla.org/mozilla-central/rev/0b08a5ce65ae

Bug 1274219 - Remove SEC_NORMAL from /browser/components/feeds/FeedWriter.js
https://hg.mozilla.org/mozilla-central/rev/369099dfb2b1

There were some other callsites in feedconverter.js and feedwriter.js updated in the bugs but they are now gone starting with 2.53 (with backports).

[Approval Request Comment]
Regression caused by (bug #): see comment.
User impact if declined: deprecation message.
Testing completed (on m-c, etc.): 2.53
Risk to taking this patch (and alternatives if risky): low. It just works.
String changes made by this patch: --

Comment 2

[Ian Neal]

Comment on attachment 9083885 [details] [diff] [review]
1572301-feedschannel-253.patch


>+    // this channel is not going to be openend, use a nullPrincipal
>+    // and the most restrctive securityFlag.
Nit: typos! Probably should be:
// This channel is not going to be opened, use a nullPrincipal
// and the most restrictive securityFlag.

r/a=me with those fixed

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/6968975cc5b4
Provide correct loadinfo in feedwriter.js. r=IanN

Comment 4

[Frank-Rainer Grahl (:frg)]

https://hg.mozilla.org/releases/comm-esr60/rev/9808d6a96ac92330212e2c8a9e441e6550dae2f3