Closed Bug 1572305 Opened Last month Closed Last month

Port Bug 1223225 "Use channel.asyncOpen2() in browser/base/content/nsContextMenu.js" to SeaMonkey

Categories

(SeaMonkey :: Security, enhancement)

Product:
SeaMonkey
Component:
Security
Type:
enhancement
Priority:
Not set

Tracking

(seamonkey2.49esr wontfix, seamonkey2.53 affected, seamonkey2.57esr fixed, seamonkey2.63 wontfix)

Status:
RESOLVED FIXED
Milestone:
seamonkey2.67
Tracking Flags:
Tracking Status
seamonkey2.49esr --- wontfix
seamonkey2.53 --- affected
seamonkey2.57esr --- fixed
seamonkey2.63 --- wontfix

People

(Reporter: frg, Assigned: frg)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

1572305-nscontexmenu-channel-253.patch
2.42 KB, patch
iann_bugzilla
: review+
iann_bugzilla
: approval-comm-release+
iann_bugzilla
: approval-comm-esr60+
Details | Diff | Splinter Review

suite/base/content/nsContextMenu.js needs to be aligned here. Part of bug 1223225 was already done previously. Just the channel creation needs to be aligned and a loadInfo parameter.needs to be provided.

[Approval Request Comment]
Regression caused by (bug #): --
User impact if declined: none just outdated code
Testing completed (on m-c, etc.): 2.53
Risk to taking this patch (and alternatives if risky): low risk.
String changes made by this patch: --

Attachment #9083886 - Flags: review?(iann_bugzilla)
Attachment #9083886 - Flags: approval-comm-release?
Attachment #9083886 - Flags: approval-comm-esr60?
Comment on attachment 9083886 [details] [diff] [review]
1572305-nscontexmenu-channel-253.patch

[Triage Comment]
LGTM r/a=me
Attachment #9083886 - Flags: review?(iann_bugzilla)
Attachment #9083886 - Flags: review+
Attachment #9083886 - Flags: approval-comm-release?
Attachment #9083886 - Flags: approval-comm-release+
Attachment #9083886 - Flags: approval-comm-esr60?
Attachment #9083886 - Flags: approval-comm-esr60+

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/b9bd66756fd5
Use channel.asyncOpen2() in nsContextMenu.js. r=IanN

Status: ASSIGNED → RESOLVED
Closed: Last month
Resolution: --- → FIXED
Blocks: 1578061
You need to log in before you can comment on or make changes to this bug.