1572374 - Avoid duplication of WorkerDispatcher and workerHandler utils

Status: NEW

(DevTools :: Netmonitor, task, P3)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

The Network panel search implementation utilizes couple of worker utils:

• WorkerDispatcher
• workerHandler

devtools/client/netmonitor/src/workers/worker-utils.js

These helpers come from Debugger:
https://searchfox.org/mozilla-central/rev/9ae20497229225cb3fa729a787791f424ff8087b/devtools/client/debugger/packages/devtools-utils/src/worker-utils.js#134-135

We should avoid code duplication and move the worker-utils.js module to:
devtools/client/shared directory

Note that the Debugger version is using flow, which isn't supported in other panels so, the Network panel's version should be used.

Honza

Comment 1

[Ruchika Gosain]

Hello! I'd to take this up :)

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Sounds great, thanks for the help!

You might want to read this:
https://docs.firefox-dev.tools/getting-started/

Please go ahead and put any of your findings here in the report
Also use Request information from field (at the bottom of this page) when you have questions.

Honza

Comment 3

[Ruchika Gosain]

Attachment: Bug 1572374: worker utils r=honza

Comment 4

[Ruchika Gosain]

Hello, I've made the required changes. Let me know if they work.
Also, it would be great if you could assign this bug to me :)
Thanks

Comment 5

[Jan Honza Odvarko [:Honza] (always need-info? me)]

FYI, @Lloan there is a question in Phab from Ruchika
https://phabricator.services.mozilla.com/D47403#1441256

Honza

Comment 6

[lloan alas:[lloanalas]]

@honza

Thanks! Will answer shortly.

Comment 7

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Hubert, can you please help with the bug. The patch is already there and seems to be close to landing.

ruchikag826, still interested in this bug?

Honza

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 6 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.

Comment 9

[Clinton]

I'd love to work on this bug, could it be assigned to me?

Comment 10

[Onyinye Ezike]

Attachment: Bug 1572374 - [devtools] avoid worker utils duplication r=honza

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.

Comment 12

[BugBot [:suhaib / :marco/ :calixte]]

Clear a needinfo that is pending on an inactive user.

Inactive users most likely will not respond; if the missing information is essential and cannot be collected another way, the bug maybe should be closed as INCOMPLETE.

For more information, please visit auto_nag documentation.