Closed Bug 1572390 Opened 5 years ago Closed 5 years ago

Split server/main.js in debugger-server.js and debugger-server-connection.js

Categories

(DevTools :: General, task, P1)

task

Tracking

(firefox70 fixed)

RESOLVED FIXED
Firefox 70
Tracking Status
firefox70 --- fixed

People

(Reporter: jdescottes, Assigned: jdescottes)

References

(Blocks 1 open bug)

Details

(Whiteboard: dt-fission-m1)

Attachments

(1 file)

Spawned from Bug 1565200.
devtools/server/main.js can be split in several dedicated modules:

  • debugger-server.js to expose DebuggerServer
  • debugger-server-connection.js to expose DebuggerServerConnection

After that we may also extract connection methods (connectToFrame, connectToWorker) from debugger-server.js. Will create a follow up for that.

I would like to do some cleanup in main.js
After this initial split I would also like to extract the connectToFrame/connectToWorker blocks
But before I go too deep into this I'd like to check if this seems ok with you and if it doesn't conflict
with too many other inflight patches.

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Component: General → Debugger
Attachment #9083955 - Attachment description: Bug 1565200 - Split main.js in debugger-server and debugger-server-connection → Bug 1572390 - Split main.js in debugger-server and debugger-server-connection
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1de02e203612
Split main.js in debugger-server and debugger-server-connection r=yulia,ochameau
Component: Debugger → General
Blocks: 1572436
Priority: P3 → P1
Whiteboard: dt-fission
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
Regressions: 1573993
Whiteboard: dt-fission → dt-fission dt-fission-m1
Whiteboard: dt-fission dt-fission-m1 → dt-fission-m1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: