1572424 - You can wrongly submit the feedback form without answering to its questions

Status: RESOLVED INVALID

(Firefox :: about:logins, defect, P3)

Description

[Carmen Fat [:cfat] - Ecosystem QA]

Attachment: empty feedback.gif

[Affected Versions]:

• Nightly 70.0a1 (Build ID: 20190807215212)

[Affected Platforms]:

• All Windows
• All Mac
• All Linux

[Steps to reproduce]:

1. Open the latest Nightly browser and navigate to "about:logins" page.
2. Click the 3 dots menu button from the top right side of the page.
3. Select the "Send Feedback" option from the menu.
4. Scroll down the Feedback page and click the "Submit" button.
5. Observe what happens next.

[Expected results]:

• Errors stating that the questions require answers are displayed.

[Actual results]:

• The empty feedback is submitted and the user is redirected to the "Thank you" page.

[Notes]:

• Attached a screen recording with the issue.

Comment 1

[Sam Foster [:sfoster] (he/him)]

Sandy, does it make sense to configure that feedback form to require at least some input (I'm assuming surveygizmo provides a way to do this)

Comment 2

[Sandy Sage]

We intentionally decided not to 'require' any of the questions as many best practices highlight that can be a barrier to use. If that ends up feeling "broken" for many users then we can require the first and only question. It's a really easy configuration to change.

Comment 3

[Matthew N. [:MattN]]

ok, marking as WONTFIX for now then… we can re-open if it becomes an issue for users.

Comment 4

[Matthew N. [:MattN]]

I guess INVALID is better