Closed Bug 1572441 Opened 6 months ago Closed 5 months ago

Localize Protection panel message

Categories

(Firefox :: Messaging System, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 70
Iteration:
70.3 - Aug 5 - 18
Tracking Status
firefox70 --- fixed

People

(Reporter: Mardak, Assigned: Mardak)

References

Details

(Keywords: github-merged, Whiteboard: [privacy-panel][skyline][uj])

Attachments

(1 file)

Bug 1567522 landed with hardcoded english strings and additional methods in ToolbarPanelHub.jsm that aren't tested:

08 08 2019 06:30:50.376:ERROR [reporter.coverage-istanbul]: Coverage for statements (72.84%) in file activity-stream/lib/ToolbarPanelHub.jsm does not meet per file threshold (100%)
08 08 2019 06:30:50.376:ERROR [reporter.coverage-istanbul]: Coverage for lines (72.84%) in file activity-stream/lib/ToolbarPanelHub.jsm does not meet per file threshold (100%)
08 08 2019 06:30:50.376:ERROR [reporter.coverage-istanbul]: Coverage for branches (65.38%) in file activity-stream/lib/ToolbarPanelHub.jsm does not meet per file threshold (84%)
08 08 2019 06:30:50.376:ERROR [reporter.coverage-istanbul]: Coverage for functions (84.85%) in file activity-stream/lib/ToolbarPanelHub.jsm does not meet per file threshold (100%)
Depends on: 1567522

Andrei, can you take this?

Flags: needinfo?(andrei.br92)
Whiteboard: [privacy-panel][skyline]

I believe andreio is out until the 16th, so I'll take this.

Assignee: nobody → edilee
Flags: needinfo?(andrei.br92)

Thanks!

Status: NEW → ASSIGNED
Whiteboard: [privacy-panel][skyline] → [privacy-panel][skyline][uj]
Blocks: 1574334
Status: ASSIGNED → RESOLVED
Iteration: --- → 70.3 - Aug 5 - 18
Closed: 5 months ago
Keywords: github-merged
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
You need to log in before you can comment on or make changes to this bug.