Move Windows prefs to winpref.js

VERIFIED FIXED

Status

VERIFIED FIXED
17 years ago
14 years ago

People

(Reporter: stdowa+bugzilla, Assigned: smeredith)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment, 1 obsolete attachment)

1.89 KB, patch
sfraser_bugs
: review+
bryner
: superreview+
Details | Diff | Splinter Review
(Reporter)

Description

17 years ago
The Windows dialup pref, network.autodial-helper.enabled, should be moved to 
winpref.js instead of being in all.js.
(Reporter)

Comment 1

17 years ago
Created attachment 92654 [details] [diff] [review]
patch

Comment 2

17 years ago
Is that the only pref that needs moving?
(Reporter)

Comment 3

17 years ago
mscott, should the alert prefs be moved to winpref.js?
Summary: Move Windows dialup pref to winpref.js → Move Windows prefs to winpref.js

Comment 4

16 years ago
no i wouldn't move it. that pref will eventually work on all platforms.
(Reporter)

Comment 5

16 years ago
Created attachment 96947 [details] [diff] [review]
patch v1.1
Attachment #92654 - Attachment is obsolete: true

Updated

16 years ago
Attachment #96947 - Flags: review+

Comment 6

16 years ago
Comment on attachment 96947 [details] [diff] [review]
patch v1.1

r=sfraser.
Do we really want long comments in prefs files? They only add to startup time,
by increasing the file size, and the amount of data that the JS engine has to
parse at startup.
Comment on attachment 96947 [details] [diff] [review]
patch v1.1

sr=bryner
Attachment #96947 - Flags: superreview+
(Reporter)

Comment 8

16 years ago
patch checked in, -> fixed.
Status: NEW → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
vrfy'd fixed, with 2002.10.22.08 comm trunk.
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.