Closed Bug 1572470 Opened 3 months ago Closed 2 months ago

Add wikipedia to engines.json

Categories

(Firefox :: Search, task, P1)

task
Points:
5

Tracking

()

RESOLVED FIXED
Firefox 70
Iteration:
70.4 - Aug 19 - Sep 1
Tracking Status
firefox70 --- fixed

People

(Reporter: daleharvey, Assigned: daleharvey)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

So wikipedia has 128 matches in https://searchfox.org/mozilla-central/source/browser/components/search/extensions/list.json, I believe its available in every locale configuration and in the vast majority of cases the locale of the engine matches the users locale

One of the side benefits to switching to WebExtensions for search engines is that we may be able to use the WebExtensions to handle the localisation of engines instead of us doing so manually in SearchService. We need to do that on an opt in case by case basis and it seems like wikipedia might be a good first choice

I think we could do something like

{
  "engineName": "wikipedia",
  "webExtensionId": "wikipedia@search.mozilla.org",
  "appliesTo": [{ 
    "included": { "everywhere": true " },
    "webExtensionLocale": "$USER_LOCALE"
  }]
},

And have webextensions install the engine matching the users locale instead of listing wikipedia 128 times

Iteration: --- → 70.4 - Aug 19 - Sep 1
Points: --- → 5
Assignee: nobody → dharvey
Priority: -- → P1
Pushed by dharvey@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/19b8d6a399f6
Add wikipedia to engines.json r=Standard8
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
You need to log in before you can comment on or make changes to this bug.