1572470 - Add wikipedia to engines.json

Status: RESOLVED FIXED

(Firefox :: Search, task, P1)

Description

[Dale Harvey (:daleharvey)]

As a follow up to https://bugzilla.mozilla.org/show_bug.cgi?id=1542243

Comment 1

[Dale Harvey (:daleharvey)]

So wikipedia has 128 matches in https://searchfox.org/mozilla-central/source/browser/components/search/extensions/list.json, I believe its available in every locale configuration and in the vast majority of cases the locale of the engine matches the users locale

One of the side benefits to switching to WebExtensions for search engines is that we may be able to use the WebExtensions to handle the localisation of engines instead of us doing so manually in SearchService. We need to do that on an opt in case by case basis and it seems like wikipedia might be a good first choice

I think we could do something like

{
  "engineName": "wikipedia",
  "webExtensionId": "[e-mail]",
  "appliesTo": [{ 
    "included": { "everywhere": true " },
    "webExtensionLocale": "$USER_LOCALE"
  }]
},

And have webextensions install the engine matching the users locale instead of listing wikipedia 128 times

Comment 2

[Dale Harvey (:daleharvey)]

Attachment: Bug 1572470 - Add wikipedia to engines.json

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/19b8d6a399f6
Add wikipedia to engines.json r=Standard8

Comment 4

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/19b8d6a399f6

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/releases/mozilla-beta/rev/19b8d6a399f6