Closed Bug 1572479 Opened 4 months ago Closed 3 months ago

Multiple characters are wrongly displayed in the multi-preference-experiment's study icon on the about:studies page

Categories

(Firefox :: Normandy Client, defect, P1)

Desktop
All
defect

Tracking

()

VERIFIED FIXED
Firefox 70
Tracking Status
firefox69 --- wontfix
firefox70 --- fixed

People

(Reporter: ppop, Assigned: mythmon)

Details

Attachments

(4 files)

Attached image mpe_study_icon.png

[Affected Platforms]:

  • All Windows
  • All Mac
  • All Linux

[Affected Versions]:

  • Firefox Nightly 70.0a1, Build ID 20190808093310
  • Firefox Beta 69.0b11, Build ID 20190805120428

[Prerequisites]:

[Steps to reproduce]:

  1. Open the browser with the profile from prerequisites.
  2. Navigate to about:studies and observe the active experiment's study icon.

[Expected result]:

  • Only the first letter of the recipe's "userFacingName" attribute is displayed as a study icon.

[Actual result]:

  • Multiple characters are displayed in the study icon.

[Notes]:

  • If no spaces are present the entire string is displayed shifting the position of other page elements.
  • The issue is not reproducible with the branched-addon-study action. I don't think this is a validation issue as branched-addon-studies use a similar json blob.
  • I have attached a screenshot of the issue:
Assignee: nobody → mcooper
Status: NEW → ASSIGNED

Naming this field better matches the intent of the field, other actions, and
the schemas used by the recipes on the server. Overall it makes the code less
confusing, and more consistent.

FYI your STR template has an error in it. When you say

Have the "extensions.shield-recipe-client.api_url" pref set to "https://stage.normandy.nonprod.cloudops.mozgcp.net/api/v1".

the preference should be app.normandy.api_url. extensions.shield-recipe-client.api_url is an old preference name we haven't used in a long time.

Also, thank you for including a link to the recipe that revealed the bug. It made it a lot easier to reproduce and fix this bug.

Attachment #9084176 - Attachment description: Bug 1572479 - Rename PreferenceExperiment.name to PreferenceExperiment.slug, and fix revealed about:studies UI bug. r=rdalal! → Bug 1572479 pt2 - Rename preference experiment name to slug
Attachment #9084176 - Attachment description: Bug 1572479 pt2 - Rename preference experiment name to slug → Bug 1572479 pt2 - Rename preference experiment name to slug r=rdalal!

The priority flag is not set for this bug.
:mythmon, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(mcooper)
Flags: needinfo?(mcooper)
Priority: -- → P1
Attachment #9085626 - Attachment description: Bug 1572479 pt1 - Move PreferenceExperiment migrations to NormandyMigrations.jsm r=rdalal! → Bug 1572479 pt1 - Move PreferenceExperiment migrations to NormandyMigrations.jsm
Attachment #9085626 - Attachment description: Bug 1572479 pt1 - Move PreferenceExperiment migrations to NormandyMigrations.jsm → Bug 1572479 pt1 - Move PreferenceExperiment migrations to NormandyMigrations.jsm r=rdalal!
Attachment #9085626 - Attachment description: Bug 1572479 pt1 - Move PreferenceExperiment migrations to NormandyMigrations.jsm r=rdalal! → Bug 1572479 pt1 - Move PreferenceExperiment migrations to NormandyMigrations.jsm
Attachment #9084176 - Attachment description: Bug 1572479 pt2 - Rename preference experiment name to slug r=rdalal! → Bug 1572479 pt2 - Rename preference experiment name to slug
Attachment #9085627 - Attachment description: Bug 1572479 pt3 - Fix study icon for multi-preference-experiments in about:studies r=rdalal! → Bug 1572479 pt3 - Fix study icon for multi-preference-experiments in about:studies
Pushed by mcooper@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6d157db92bc9
pt1 - Move PreferenceExperiment migrations to NormandyMigrations.jsm r=glasserc
https://hg.mozilla.org/integration/autoland/rev/1c29b632b6eb
pt2 - Rename preference experiment name to slug r=rdalal
https://hg.mozilla.org/integration/autoland/rev/d986d84d5d29
pt3 - Fix study icon for multi-preference-experiments in about:studies r=rdalal
Pushed by malexandru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c88dc69728ed
pt4 - Fix tests outside of Normandy a=fix CLOSED TREE

I have verified that this issue is no longer reproducible and only the first character is displayed as expected. Tested using Firefox Beta 69.0 and Firefox Nightly 71.0a1 on Windows 10 x64, macOS 10.14 and Ubuntu 16.04

I will mark the issue as verified-fixed.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.