1572492 - [Protections Panel] Info message background and learn more link aren't correctly placed in RTL

Status: RESOLVED FIXED

(Firefox :: Site Identity, defect, P1)

Description

[(no longer active)]

Attachment: panel-rtl.png

Please see the screenshot. The problems are:

• The header image isn't mirrored.
• The learn more button isn't mirrored.

Comment 2

[Itiel]

The first issue can be easily fixed, just change:
https://searchfox.org/mozilla-central/rev/ec806131cb7bcd1c26c254d25cd5ab8a61b2aeb6/browser/themes/shared/customizableui/panelUI.inc.css#1116
to float: inline-end.

The second issue could be a bit trickier, see bug 1539633. Mirroring this image will mirror also the shield icon.
Probably another SVG for RTL is needed here?
Or, simply mirror this one and in bug 1539633 make sure to mirror all the rest.

Comment 3

[Andrei Oprea [:andreio]]

(In reply to Itiel from comment #2)

The second issue could be a bit trickier, see bug 1539633. Mirroring this image will mirror also the shield icon.
Probably another SVG for RTL is needed here?
Or, simply mirror this one and in bug 1539633 make sure to mirror all the rest.

After discussing this with design the decision was to not change the background positioning in RTL mode.

Comment 4

[Andrei Oprea [:andreio]]

Attachment: Bug 1572492 - Protections Panel message learn more link is incorrectly placed in RTL

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/76e4b9536c75
Protections Panel message learn more link is incorrectly placed in RTL r=nhnt11

Comment 6

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/76e4b9536c75