Closed Bug 1572500 Opened 4 months ago Closed 4 months ago

keyword based searches - double counting of search volume

Categories

(Firefox :: Address Bar, defect, P1)

defect
Points:
2

Tracking

()

RESOLVED FIXED
Firefox 70
Iteration:
70.4 - Aug 19 - Sep 1
Tracking Status
firefox70 --- fixed

People

(Reporter: arana, Assigned: adw, NeedInfo)

Details

Attachments

(1 file)

There is a new data sources called "alias" being reported in the data tables and the search volume from the source looks significant. These are searches made using "keywords" e.g searches made with "@google" . Search shortcuts on the new tab page is one of the ways to make such a search and has led to the recent increase in searches made using keywords. Please see the query below

https://sql.telemetry.mozilla.org/queries/63783/source

The searches reported for source "alias" are getting double counted under other "source names" as well (mostly urlbar). The searches made under "alias" need to be reported as a separate source and these searches need to be excluded from other "source names" (example of source names are urlbar, searchbar, newtab etc.)

Let me know if you need more information on this

Since this is filed under dataset:search, just want to add that this may relate to main_summary data table as well.

IIUC, this would be a bug in the telemetry.

:mconnor, do you know who added the measurements? cc:standard8 for context.

Flags: needinfo?(standard8)
Flags: needinfo?(mconnor)

Drew's probably best to look at this.

Flags: needinfo?(standard8) → needinfo?(adw)

(In reply to arana from comment #0)

Please see the query below

https://sql.telemetry.mozilla.org/queries/63783/source

I don't have permission to view that page, but I think I understand. This is about SEARCH_COUNTS histogram telemetry, right? In bug 1499193, we started double counting @alias searches, once under the "urlbar" source and once under the "alias" source. e.g., both "google-b-1-d.urlbar" and "google-b-1-d.alias". That started in Firefox 64. You're asking that we count them only under the "alias" source, right?

The searches reported for source "alias" are getting double counted under other "source names" as well (mostly urlbar).

fwiw and in case it's important, I would be surprised if it's not entirely urlbar. I don't immediately see how other sources would also be capturing aliases since aliases are only recognized in the urlbar.

Flags: needinfo?(adw)

I don't have permission to view that page

Fixed!

That started in Firefox 64. You're asking that we count them only under the "alias" source, right?

That's correct. Can I list you as the assignee, Drew?

Flags: needinfo?(adw)

Sure. I'd also like to move this to Firefox :: Address Bar, if that's OK.

Assignee: nobody → adw
Status: NEW → ASSIGNED
Points: --- → 2
Component: Datasets: Search → Address Bar
Flags: needinfo?(adw)
Priority: -- → P1
Product: Data Platform and Tools → Firefox
Iteration: --- → 70.3 - Aug 5 - 18
Iteration: 70.3 - Aug 5 - 18 → 70.4 - Aug 19 - Sep 1
Pushed by dwillcoxon@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bc3079511334
Count internal @search keyword searches separately from other urlbar searches in the SEARCH_COUNTS histogram. r=Standard8
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
You need to log in before you can comment on or make changes to this bug.