1572509 - PingUploadWorker may get stuck in infinite loop if upload disabled.

Status: RESOLVED FIXED

(Data Platform and Tools :: Glean: SDK, defect, P1)

Description

[Travis Long [:travis_]]

The current ping upload worker is checking the success of the uploadPings() function to determine if it reports that the worker needs to retry():

    override fun doWork(): Result {
        if (!uploadPings()) {
            return Result.retry()
        }

        return Result.success()
    }

This is a problem because the uploadPings() function returns false if getUploadEnabled() is false, creating a situation where the worker would continue to run, and retry when upload is disabled.

Comment 1

[Travis Long [:travis_]]

Attachment: GitHub Pull Request

PR for glean-ac

Comment 2

[Travis Long [:travis_]]

Attachment: GitHub Pull Request

PR for glean-rs

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c425859aa7d8
[components]  Bug 1572509 -  Fix PingUploadWorker loop if upload disabled