Closed Bug 1572529 Opened 4 months ago Closed 4 months ago

Convert vsync.parentProcess.highPriority to just use BrowserTabsRemoteAutoStart directly

Categories

(Core :: Preferences: Backend, task)

task
Not set

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: KrisWright, Assigned: KrisWright)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Currently the pref vsync.parentProcess.highPriority is set with BrowserTabsRemoteAutoStart [1], and then a mirror variable sHighPriorityPrefValue uses the pref value. This pref doesn't appear to be used anywhere else, and it doesn't really fit the pattern of prefs. sHighPriorityPrefValue could probably just store the value from BrowserTabsRemoteAutoStart directly and use it from there.

[1] https://searchfox.org/mozilla-central/rev/9ae20497229225cb3fa729a787791f424ff8087b/layout/base/nsRefreshDriver.cpp#526

I'm looking at the pref and from a quick search I don't see it being used anywhere. It also doesn't have an entry in all.js or other corresponding files. As it stands I don't think it would cause any problems to remove the pref entirely and just use a code constant. If not, the way we get the value will have to be refactored to fit the pattern of prefs. In BrowserTabsAutoRemoteStart it looks like the value relies on a few factors, including the value of a different pref, so this may not be possible.

Ehsan, since you reviewed bug 1352523, is it okay to remove the vsync.parentProcess.highPriority pref and store the value directly instead?

Flags: needinfo?(ehsan)

Hi Kris,

The purpose behind this pref was to use it as an emergency measure to turn off the feature. But ~2 years have passed, I think we can now remove both the pref and sHighPriorityPrefValue and the code that assumes it would be false.

Olli, what do you think?

Flags: needinfo?(ehsan) → needinfo?(bugs)

We have still non-e10s usage, so we need mozilla::BrowserTabsRemoteAutostart() call.
But just initializing sHighPriorityEnabled to mozilla::BrowserTabsRemoteAutostart() should be fine.

Flags: needinfo?(bugs)

Oh right yeah, we should keep non-e10s working of course.

Summary: Convert vsync.parentProcess.highPriority to just use BrowserTabsAutoRemoteStart directly → Convert vsync.parentProcess.highPriority to just use BrowserTabsRemoteAutoStart directly

Removes vsync.parentProcess.highPriority pref and stores BrowserTabsRemoteAutostart() directly into sHighPriorityEnabled.

Pushed by kwright@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/88611512b474
Remove vsync.parentProcess.highPriority . r=smaug
Assignee: nobody → kwright
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.