Closed Bug 1572564 Opened 1 year ago Closed 5 months ago

tab order in protections pop-up panel is wrong

Categories

(Firefox :: Protections UI, defect, P1)

Unspecified
Windows 10
defect

Tracking

()

RESOLVED WORKSFORME
Tracking Status
firefox70 --- wontfix

People

(Reporter: asa, Assigned: ewright)

Details

(Keywords: access, Whiteboard: [privacy-panel][skyline][access-p2])

Attachments

(1 obsolete file)

In today's nightly build on Mac and Windows, the tab order in the protections pop-up panel is wrong.

Steps:

  1. With this bug report loaded, activate the panel (shift+tab from the addressbar and hit enter)
  2. With the pane open, tab through the items in the panel.

Results: Tabbing goes first to the information "i" icon (no focus indication on mac) then to the "Site not working link" then to the protections toggle widget (no focus indication on mac) then to the not blocking "why" link, then to Tracking Content sub panel label, then it jumps back up to the Tracking Cookies sub panel label which had been skipped, then to the Protection Settings item (no focus indication on windows) then to the Show Full Report item (no focus indication on windows.)

Expected results: Tabbing flows down the panel without skipping items and highlights every item focused.

Tested on Windows 10, Firefox 70.0a1 (2019-08-08) (64-bit) and macOS 10.14.5 Firefox 70.0a1 (2019-08-08) (64-bit)

Keywords: access
Whiteboard: [skyline]

The button with ID protections-popup-info-button also is missing an accessible label.Note that from an accessibility standpoint, the flow sounds logical, e. g. it must be visually reagganged to appear not in order. From the way the accessibility tree looks, keyboard focus follows DOM order. It's jus the visuals that seem out of sync here, probably due to some fancy CSS rearranging.

Whiteboard: [skyline] → [privacy-panel][skyline]
Priority: -- → P1
Whiteboard: [privacy-panel][skyline] → [privacy-panel][skyline][access-p2]

I think this was already fixed in another bug?
This seems to work okay atm.

Agreed. This seems to be working as expected.

Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → WORKSFORME
Assignee: nobody → ewright

Comment on attachment 9113559 [details]
Bug 1572564 - Tab arrow buttons move in correct order in rtl

Revision D55854 was moved to bug 1594825. Setting attachment 9113559 [details] to obsolete.

Attachment #9113559 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.