Closed Bug 1572608 Opened 5 years ago Closed 3 years ago

Intermittent browser/components/customizableui/test/browser_PanelMultiView_keyboard.js | Uncaught exception - at chrome://mochitests/content/browser/browser/components/customizableui/test/browser_PanelMultiView_keyboard.js:399 - TypeError: textarea is nul

Categories

(Firefox :: Toolbars and Customization, defect, P5)

Product:
Firefox
Component:
Toolbars and Customization
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
81 Branch
Tracking Flags:
Tracking Status
firefox-esr68 --- unaffected
firefox-esr78 --- unaffected
firefox79 --- unaffected
firefox80 --- fixed
firefox81 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: Jamie)

References

Details

(Keywords: intermittent-failure, regression, Whiteboard: [stockwell unknown])

Attachments

(1 file)

Bug 1572608: browser_PanelMultiView_keyboard.js: If embedded documents aren't loaded yet, wait for them to load before trying to interact with them.
47 bytes, text/x-phabricator-request
Details | Review

Filed by: ccoroiu [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=260709002&repo=autoland
Full log: https://queue.taskcluster.net/v1/task/BrfQ8NvpT-2TiG_XTS2JOg/runs/0/artifacts/public/logs/live_backing.log

[task 2019-08-09T01:27:33.453Z] 01:27:33 INFO - TEST-PASS | browser/components/customizableui/test/browser_PanelMultiView_keyboard.js | doc focused after Tab pressed -
[task 2019-08-09T01:27:33.454Z] 01:27:33 INFO - Buffered messages finished
[task 2019-08-09T01:27:33.454Z] 01:27:33 INFO - TEST-UNEXPECTED-FAIL | browser/components/customizableui/test/browser_PanelMultiView_keyboard.js | Uncaught exception - at chrome://mochitests/content/browser/browser/components/customizableui/test/browser_PanelMultiView_keyboard.js:399 - TypeError: textarea is null
[task 2019-08-09T01:27:33.454Z] 01:27:33 INFO - Stack trace:
[task 2019-08-09T01:27:33.454Z] 01:27:33 INFO - testTabArrowsEmbeddedDoc@chrome://mochitests/content/browser/browser/components/customizableui/test/browser_PanelMultiView_keyboard.js:399:3
[task 2019-08-09T01:27:33.454Z] 01:27:33 INFO - asynctestTabArrowsBrowser@chrome://mochitests/content/browser/browser/components/customizableui/test/browser_PanelMultiView_keyboard.js:416:9
[task 2019-08-09T01:27:33.454Z] 01:27:33 INFO - Tester_execTest/<@chrome://mochikit/content/browser-test.js:1346:34
[task 2019-08-09T01:27:33.454Z] 01:27:33 INFO - asyncTester_execTest@chrome://mochikit/content/browser-test.js:1381:11
[task 2019-08-09T01:27:33.454Z] 01:27:33 INFO - nextTest/<@chrome://mochikit/content/browser-test.js:1209:14
[task 2019-08-09T01:27:33.454Z] 01:27:33 INFO - SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:803:67
[task 2019-08-09T01:27:33.454Z] 01:27:33 INFO - Leaving test bound testTabArrowsBrowser
[task 2019-08-09T01:27:33.454Z] 01:27:33 INFO - Entering test bound testTabArrowsIframe
[task 2019-08-09T01:27:33.454Z] 01:27:33 INFO - GECKO(1730) | --DOMWINDOW == 6 (0x11a9d2c00) [pid = 1732] [serial = 149] [outer = 0x0] [url = about:blank]
[task 2019-08-09T01:27:33.455Z] 01:27:33 INFO - GECKO(1730) | --DOMWINDOW == 5 (0x11ac59c00) [pid = 1732] [serial = 152] [outer = 0x0] [url = about:blank]
[task 2019-08-09T01:27:33.455Z] 01:27:33 INFO - GECKO(1730) | --DOCSHELL 0x11a9ae000 == 1 [pid = 1732] [id = {c0852b94-0c0b-f642-9f0e-6686470702ed}] [url = about:blank]
[task 2019-08-09T01:27:33.455Z] 01:27:33 INFO - Console message: [JavaScript Error: "The character encoding of the HTML document was not declared. The document will render with garbled text in some browser configurations if the document contains characters from outside the US-ASCII range. The character encoding of the page must be declared in the document or in the transfer protocol." {file: "data:text/html,<textarea id="docTextarea">value</textarea><button id="docButton"></button>" line: 0}]
[task 2019-08-09T01:27:33.455Z] 01:27:33 INFO - GECKO(1730) | --DOMWINDOW == 4 (0x1223527a0) [pid = 1732] [serial = 153] [outer = 0x0] [url = about:blank]
[task 2019-08-09T01:27:33.731Z] 01:27:33 INFO - GECKO(1730) | --DOMWINDOW == 4 (0x11f53cc00) [pid = 1733] [serial = 155] [outer = 0x0] [url = about:blank]
[task 2019-08-09T01:27:33.731Z] 01:27:33 INFO - GECKO(1730) | --DOMWINDOW == 3 (0x11f537800) [pid = 1733] [serial = 152] [outer = 0x0] [url = about:blank]
[task 2019-08-09T01:27:33.731Z] 01:27:33 INFO - GECKO(1730) | --DOCSHELL 0x10ef48000 == 0 [pid = 1733] [id = {688bea6e-b392-e649-ae31-40a7fc229b8b}] [url = about:blank]
[task 2019-08-09T01:27:34.736Z] 01:27:34 INFO - GECKO(1730) | --DOMWINDOW == 97 (0x12fb5c400) [pid = 1730] [serial = 168] [outer = 0x0] [url = about:blank]
[task 2019-08-09T01:27:34.736Z] 01:27:34 INFO - GECKO(1730) | --DOMWINDOW == 96 (0x15df9c800) [pid = 1730] [serial = 166] [outer = 0x0] [url = about:blank]
[task 2019-08-09T01:27:34.737Z] 01:27:34 INFO - GECKO(1730) | --DOCSHELL 0x16c790000 == 31 [pid = 1730] [id = {c4940ecc-9a7f-f447-9025-d33dc0476c28}] [url = about:blank]
[task 2019-08-09T01:27:34.737Z] 01:27:34 INFO - GECKO(1730) | --DOMWINDOW == 95 (0x162954c00) [pid = 1730] [serial = 174] [outer = 0x0] [url = about:blank]
[task 2019-08-09T01:27:34.737Z] 01:27:34 INFO - GECKO(1730) | --DOMWINDOW == 94 (0x161690000) [pid = 1730] [serial = 173] [outer = 0x0] [url = about:blank]
[task 2019-08-09T01:27:34.747Z] 01:27:34 INFO - GECKO(1730) | --DOMWINDOW == 93 (0x1613a5000) [pid = 1730] [serial = 179] [outer = 0x0] [url = about:blank]
[task 2019-08-09T01:27:34.747Z] 01:27:34 INFO - GECKO(1730) | --DOMWINDOW == 92 (0x15e1d4800) [pid = 1730] [serial = 176] [outer = 0x0] [url = about:blank]
[task 2019-08-09T01:27:34.747Z] 01:27:34 INFO - GECKO(1730) | --DOMWINDOW == 91 (0x15f798400) [pid = 1730] [serial = 182] [outer = 0x0] [url = about:blank]
[task 2019-08-09T01:27:34.747Z] 01:27:34 INFO - GECKO(1730) | --DOCSHELL 0x110746800 == 30 [pid = 1730] [id = {53565a13-fe4d-3a4d-9c43-5bcf8a9acf9d}] [url = about:mozilla]
[task 2019-08-09T01:27:34.747Z] 01:27:34 INFO - GECKO(1730) | --DOMWINDOW == 90 (0x163117800) [pid = 1730] [serial = 184] [outer = 0x0] [url = about:blank]

https://wiki.mozilla.org/Bug_Triage#Intermittent_Test_Failure_Cleanup

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → INCOMPLETE

Recent log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=280447465&repo=mozilla-central&lineNumber=12341

Status: RESOLVED → REOPENED
Resolution: INCOMPLETE → ---

https://wiki.mozilla.org/Bug_Triage#Intermittent_Test_Failure_Cleanup
For more information, please visit auto_nag documentation.

Status: REOPENED → RESOLVED
Closed: 5 years ago → 4 years ago
Resolution: --- → INCOMPLETE

Recent failure: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=299423985&repo=autoland&lineNumber=2552

Status: RESOLVED → REOPENED
Resolution: INCOMPLETE → ---

In the last 7 days there have been 21 occurrences on macosx1014-64 debug and some on windows10-64 asan.

Recent failure: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=301469805&repo=autoland&lineNumber=8148

[task 2020-05-08T21:47:44.004Z] 21:47:44     INFO - Leaving test bound testActivationMousedown
[task 2020-05-08T21:47:44.004Z] 21:47:44     INFO - Entering test bound testTabArrowsBrowser
[task 2020-05-08T21:47:44.004Z] 21:47:44     INFO - Waiting for focus on docBack
[task 2020-05-08T21:47:44.004Z] 21:47:44     INFO - TEST-PASS | browser/components/customizableui/test/browser_PanelMultiView_keyboard.js | docBack focused after Tab pressed - 
[task 2020-05-08T21:47:44.004Z] 21:47:44     INFO - Waiting for focus on doc
[task 2020-05-08T21:47:44.004Z] 21:47:44     INFO - TEST-PASS | browser/components/customizableui/test/browser_PanelMultiView_keyboard.js | doc focused after Tab pressed - 
[task 2020-05-08T21:47:44.005Z] 21:47:44     INFO - Buffered messages finished
[task 2020-05-08T21:47:44.005Z] 21:47:44     INFO - TEST-UNEXPECTED-FAIL | browser/components/customizableui/test/browser_PanelMultiView_keyboard.js | Uncaught exception - at chrome://mochitests/content/browser/browser/components/customizableui/test/browser_PanelMultiView_keyboard.js:472 - TypeError: can't access property "focus", textarea is null
[task 2020-05-08T21:47:44.005Z] 21:47:44     INFO - Stack trace:
[task 2020-05-08T21:47:44.005Z] 21:47:44     INFO - testTabArrowsEmbeddedDoc@chrome://mochitests/content/browser/browser/components/customizableui/test/browser_PanelMultiView_keyboard.js:472:3
[task 2020-05-08T21:47:44.005Z] 21:47:44     INFO - async*testTabArrowsBrowser@chrome://mochitests/content/browser/browser/components/customizableui/test/browser_PanelMultiView_keyboard.js:489:9
[task 2020-05-08T21:47:44.005Z] 21:47:44     INFO - Tester_execTest/<@chrome://mochikit/content/browser-test.js:1064:34
[task 2020-05-08T21:47:44.005Z] 21:47:44     INFO - async*Tester_execTest@chrome://mochikit/content/browser-test.js:1104:11
[task 2020-05-08T21:47:44.005Z] 21:47:44     INFO - nextTest/<@chrome://mochikit/content/browser-test.js:927:14
[task 2020-05-08T21:47:44.005Z] 21:47:44     INFO - SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:918:23
[task 2020-05-08T21:47:44.005Z] 21:47:44     INFO - Leaving test bound testTabArrowsBrowser
[task 2020-05-08T21:47:44.005Z] 21:47:44     INFO - Entering test bound testTabArrowsIframe
[task 2020-05-08T21:47:44.005Z] 21:47:44     INFO - GECKO(1830) | [Parent 1830: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 78 (0x122dcd400) [pid = 1830] [serial = 185] [outer = 0x157eb19a0]
[task 2020-05-08T21:47:44.005Z] 21:47:44     INFO - Console message: [JavaScript Error: "The character encoding of the HTML document was not declared. The document will render with garbled text in some browser configurations if the document contains characters from outside the US-ASCII range. The character encoding of the page must be declared in the document or in the transfer protocol." {file: "data:text/html,<textarea id="docTextarea">value</textarea><button id="docButton"></button>" line: 0}]
[task 2020-05-08T21:47:44.902Z] 21:47:44     INFO - GECKO(1830) | [Child 1832: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 4 (0x125dc0400) [pid = 1832] [serial = 160] [outer = 0x0] [url = about:blank]
[task 2020-05-08T21:47:44.923Z] 21:47:44     INFO - GECKO(1830) | [Child 1832: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 3 (0x125b3e260) [pid = 1832] [serial = 156] [outer = 0x0] [url = about:blank]
...

Please take a look if this should be disabled on debug (all failures are on debug).

Flags: needinfo?(gijskruitbosch+bugs)

I'm about to head into a week of PTO so I'm not in a great place to investigate this further. I'd like to understand better why it's failing on debug though. Jamie, do you have cycles?

Flags: needinfo?(gijskruitbosch+bugs) → needinfo?(jteh)

I took a quick look at this. My suspicion is that the document isn't finished loading yet when we try to get the textarea. I guess debug builds run slower, so it takes longer to load. Waiting for the embedded doc to load should fix that. Unfortunately, when I went to test it, I discovered my local environment seems to be busted, so this will have to wait until after the weekend.

Whiteboard: [stockwell needswork:owner]
Assignee: nobody → jteh
Flags: needinfo?(jteh)
Pushed by jteh@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c093db737948
browser_PanelMultiView_keyboard.js: If embedded documents aren't loaded yet, wait for them to load before trying to interact with them. r=mconley

I don't know for sure what's going on here. I can't get this to happen on try even with several retriggers. I'm pushing a further speculative fix and hoping it works.

Flags: needinfo?(jteh)
Pushed by jteh@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9d5492dd4a95
browser_PanelMultiView_keyboard.js: If embedded documents aren't loaded yet, wait for them to load before trying to interact with them. r=mconley

https://hg.mozilla.org/mozilla-central/rev/9d5492dd4a95

Status: REOPENED → RESOLVED
Closed: 4 years ago → 4 years ago
status-firefox81: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch
status-firefox80: --- → affected
Flags: needinfo?(jteh)

New occurrence: https://treeherder.mozilla.org/logviewer?job_id=326762928&repo=mozilla-esr78&lineNumber=8447

Status: RESOLVED → REOPENED
Resolution: FIXED → ---

This was fixed on 81 and the "new" occurrence is on 78 esr.

Status: REOPENED → RESOLVED
Closed: 4 years ago → 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: