1572654 - Make the FlexboxHighlighter compatible with Fission

Status: RESOLVED FIXED

(DevTools :: Inspector, task, P2)

Comment 1

[Chris Peterson [:cpeterson]]

Tentatively moving all bugs whose summaries mention "Fission" (or other Fission-related keywords) but are not assigned to a Fission Milestone to the "?" triage milestone.

This will generate a lot of bugmail, so you can filter your bugmail for the following UUID and delete them en masse:

0ee3c76a-bc79-4eb2-8d12-05dc0b68e732

Comment 2

[Chris Peterson [:cpeterson]]

Tracking for enabling Fission in Nightly (M6)

Comment 3

[Chris Peterson [:cpeterson]]

Tracking dt-fission-m2-mvp bugs for Fission Nightly milestone (M6c)

Comment 4

[Razvan Caliman [:rcaliman]]

Attachment: Bug 1572654 - Make FlexboxHighlighter compatible with Fission

Depends on D79693

Comment 5

[Neha Kochar [:neha]]

Bulk move of all m2-mvp devtools bugs to Fission M7.

Comment 6

[Razvan Caliman [:rcaliman]]

Attachment: Bug 1572654 - [devtools] Do not hide Flexbox / Grid highlighters from TextPropertyEditor when display value changes

This behavior is duplicated with existing logic in HighlightersOverlay: https://searchfox.org/mozilla-central/rev/e75e8e5b980ef18f4596a783fbc8a36621de7d1e/devtools/client/inspector/shared/highlighters-overlay.js#1503-1543

Comment 7

[Razvan Caliman [:rcaliman]]

Attachment: Bug 1572654 - [devtools] Dispatch thunk to toggle flexbox highlighter from Flexbox panel

Depends on D96078

Comment 8

[Razvan Caliman [:rcaliman]]

Attachment: Bug 1572654 - [devtools] Consolidate logic to show/hide flexbox highlighter

Depends on D96079

Comment 9

[Razvan Caliman [:rcaliman]]

Attachment: Bug 1572654 - [devtools] Delegate event handling for flexbox and grid highlighters to the Markup view

Depends on D96080

Comment 10

[Razvan Caliman [:rcaliman]]

Attachment: Bug 1572654 - [devtools] Delegate toggling flexbox highlighter from CSS property swatches up to Rules view & update tests

Depends on D96080

Comment 11

[Razvan Caliman [:rcaliman]]

Attachment: Bug 1572654 - [devtools] Refactor Layout Flexbox panel to use generic highlighter events and accessors & update tests

Depends on D96081

Comment 12

[Razvan Caliman [:rcaliman]]

Attachment: Bug 1572654 - [devtools] Refactor telemetry logging for flexbox highlighter.

Depends on D96449

Comment 13

[Razvan Caliman [:rcaliman]]

Attachment: Bug 1572654 - [devtools] Restore active flexbox highlighter on page refresh

Depends on D96730

Comment 14

[Razvan Caliman [:rcaliman]]

Attachment: Bug 1572654 - [devtools] Hide flexbox highlighter when its nodeFront is dead

Depends on D97660

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d7e0ff2985b3
[devtools] Do not hide Flexbox / Grid highlighters from TextPropertyEditor when display value changes r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/582cc20f16c0
[devtools] Dispatch thunk to toggle flexbox highlighter from Flexbox panel r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/a9568b29f3ae
[devtools] Consolidate logic to show/hide flexbox highlighter r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/945eaa3da015
[devtools] Delegate toggling flexbox highlighter from CSS property swatches up to Rules view & update tests r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/17ee02d09787
[devtools] Delegate event handling for flexbox and grid highlighters to the Markup view r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/3ba9a997fc86
[devtools] Refactor Layout Flexbox panel to use generic highlighter events and accessors & update tests r=ochameau
https://hg.mozilla.org/integration/autoland/rev/9cf9f10fbe7d
[devtools] Refactor telemetry logging for flexbox highlighter. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/f7509696a6d7
[devtools] Restore active flexbox highlighter on page refresh r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/7a68b624da3e
[devtools] Hide flexbox highlighter when its nodeFront is dead r=ochameau

Comment 16

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/d7e0ff2985b3
https://hg.mozilla.org/mozilla-central/rev/582cc20f16c0
https://hg.mozilla.org/mozilla-central/rev/a9568b29f3ae
https://hg.mozilla.org/mozilla-central/rev/945eaa3da015
https://hg.mozilla.org/mozilla-central/rev/17ee02d09787
https://hg.mozilla.org/mozilla-central/rev/3ba9a997fc86
https://hg.mozilla.org/mozilla-central/rev/9cf9f10fbe7d
https://hg.mozilla.org/mozilla-central/rev/f7509696a6d7
https://hg.mozilla.org/mozilla-central/rev/7a68b624da3e