1572666 - Consider also collect tracking resources traffic telemetry on release channel

Status: RESOLVED FIXED

(Core :: Networking, task, P2)

Description

[Gary Chen [:xeonchen]]

In bug 1533363 we started to collect tracking resource telemetry, but by default it collects only on beta/nightly channels.

To enable this, we need to

• add release_channel_collection: opt-out to Scalars.yaml
• add "releaseChannelCollection": "opt-out" to Histograms.json

Comment 1

[Gary Chen [:xeonchen]]

Hi Arthur, please confirm we're going to do this :)

Comment 2

[Gary Chen [:xeonchen]]

Attachment: Bug 1572666 - enable telemetry on release channel;

Comment 3

[Chris H-C :chutten]

Drive-by note: collection in all channels was reviewed in bug 1533363 so no further Data Review is needed.

Comment 4

[Arthur Edelstein [:arthur]]

(In reply to Gary Chen [:xeonchen] from comment #1)

Hi Arthur, please confirm we're going to do this :)

Yes, please! :)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aacc1ab5272e
enable telemetry on release channel; r=kershaw

Comment 6

[Gary Chen [:xeonchen]]

Comment on attachment 9084242 [details]
Bug 1572666 - enable telemetry on release channel;

Beta/Release Uplift Approval Request

• User impact if declined: Not able to collect telemetry on release channel.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The feature enabled in this patch has been in beta/nightly already, we just didn't realize it's default disabled in release channel.
• String changes made/needed: N/A

Comment 7

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/aacc1ab5272e

Comment 8

[Julien Cristau [:jcristau]]

Comment on attachment 9084242 [details]
Bug 1572666 - enable telemetry on release channel;

This doesn't seem to warrant inclusion in a dot release. You may want to request uplift to 69 (beta) though...

Comment 9

[Gary Chen [:xeonchen]]

Comment on attachment 9084242 [details]
Bug 1572666 - enable telemetry on release channel;

Beta/Release Uplift Approval Request

• User impact if declined: Not able to collect telemetry on release channel.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The feature enabled in this patch has been in beta/nightly already, we just didn't realize it's default disabled in release channel.
• String changes made/needed: N/A

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9084242 [details]
Bug 1572666 - enable telemetry on release channel;

Per comment 3, data review already included collecting this on the release channel. Approved for 69.0b13.

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/37a5c968f336

Comment 12

[Gary Chen [:xeonchen]]

(In reply to Julien Cristau [:jcristau] from comment #8)

Comment on attachment 9084242 [details]
Bug 1572666 - enable telemetry on release channel;

This doesn't seem to warrant inclusion in a dot release. You may want to request uplift to 69 (beta) though...

We need this to be included in release channel, otherwise we wouldn't have any data collected from v68 release.
Can you give more info how to uplift this patch to release channel?

Comment 13

[Julien Cristau [:jcristau]]

If you uplift to beta now, it'll be on the release channel when 69 goes to release in 3 weeks.

Comment 14

[Ethan Tseng [:ethan]]

Arthur, is it necessary to have the patch in 68 Release? Could you provide more information to support the decision?

Comment 15

[Arthur Edelstein [:arthur]]

(I discussed with Ethan and Gary and we decided not to uplift to 68.)