1572701 - Move login-item metadata after form action buttons in edit mode

Status: VERIFIED FIXED

(Firefox :: about:logins, defect, P3)

Description

[Simona Rosu [:srosu], Ecosystem QA]

Attachment: Sections_displayed.png

[Affected versions]:

• Firefox latest Nightly 70.0a1 (2019-08-08) (64-bit)

[Affected Platforms]:

• Mac 10.14
• Windows 10 x64
• Ubuntu 18.04 x64

[Prerequisites]:

• Have a Firefox profile with at least one saved login.

[Steps to reproduce]:

1. Open the latest Nightly browser with the profile from prerequisites.
2. Navigate to "about:logins" page and select a saved login.
3. Click on the "Edit" button.
4. Observe the area below the Password field.

[Expected result]:

• The "Created:", "Last Modified:" and "Last Used:" sections are no longer displayed.

[Actual result]:

• The "Created:", "Last Modified:" and "Last Used:" sections are still displayed.

[Notes]:

• The "Created:", "Last Modified:" and "Last Used:" sections from the “Edit” mode should be not displayed, as shown in https://mozilla.invisionapp.com/share/EJRHBMEDKF8#/screens/372931544
• Attached a screenshot with the issue.

Comment 1

[Simona Rosu [:srosu], Ecosystem QA]

Attachment: Sections_displayed.png

Comment 2

[Tim Nguyen :ntim]

Attachment: Bug 1572701 - Hide login metadata in edit mode. r=MattN

Comment 3

[Matthew N. [:MattN]]

The reason I made this P3 is because I'm not sure I agree with the bug but since it wasn't important it wasn't worth arguing about it at the time. I don't see the problem with showing this metadata when editing as it could be useful. We already don't show it for new logins where it would show a confusing unix epoch date.

The UX spec doesn't actually cover this case so I don't think this is a spec compliance issue.

Ryan, do you feel strongly that the metadata shouldn't show when editing an existing login? It seems like needlessly hiding potentially useful information. e.g. I click edit then second-guess whether I'm editing the right login with the right password and I need the date to know which password is the old vs. new one.

Comment 4

[rgaddis]

I don't disagree with showing the metadata in the edit mode (even though I didn't originally have it in the design spec, hence the QA callout potentially) but I would like the metadata to fall below the Save Changes and Cancel buttons.

Updated design attached.

Comment 5

[rgaddis]

Attachment: Lockwise Desktop Home - Edit Login.png

Comment 6

[Tim Nguyen :ntim]

Attachment: Bug 1572701 - Move login-item metadata after form action buttons in edit mode. r=MattN

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9611e86a09b4
Move login-item metadata after form action buttons in edit mode. r=MattN

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a regression, but please revert this change in case of error.

Comment 9

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/9611e86a09b4

Comment 10

[Simona Rosu [:srosu], Ecosystem QA]

I have verified this issue on the latest Nightly 70.0a1 (2019-08-20) (64-bit) on Windows 10, MacOS 10.14 and Ubuntu 16.04.

• The login-item metadata is displayed under form action buttons on the "Edit" mode.