1572758 - Unable to see Event in about:telemetry in artifact build

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect, P1)

Description

[Erica Wright [:ewright]]

I was recently adding some event telemetry using Events.yaml. The event was in the content process.

• I ran the build in artifact mode
• I visited about:telemetry and could see the event show up in "keyed scalars > dynamic" but I saw no events listed under "Events".

---

• I ran the build in regular mode
• I visited about:telemetry again and saw the event show under "events > content"

I was under the impression that an artifact build could be used for this.

Comment 1

[Chris H-C :chutten]

Definitely the artifact build should work exactly the same as a full build in this respect. Thank you for filing this bug.

Seems like there's a hole in our Build Faster support for Events, maybe related to bug 1563239

Comment 2

[Chris H-C :chutten]

I'm having difficulty reproducing this with latest code. I tried

1. Changing .mozconfig to build artifact
2. Adding a new category and event definition to Events.yaml
3. ./mach build faster && ./mach run
4. Loading about:telemetry and opening the dev console to Telemetry.setEventRecordingEnabled and Telemetry.recordEvent
5. Refreshing about:telemetry and checking the Events section

The event shows up properly, and is even summarized properly to Keyed Scalars > Parent. I must be missing something.

:ewright Can you help me find out what I'm missing?

Comment 3

[Erica Wright [:ewright]]

(In reply to Chris H-C :chutten from comment #2)

I'm having difficulty reproducing this with latest code. I tried

1. Changing .mozconfig to build artifact
2. Adding a new category and event definition to Events.yaml
3. ./mach build faster && ./mach run
4. Loading about:telemetry and opening the dev console to Telemetry.setEventRecordingEnabled and Telemetry.recordEvent
5. Refreshing about:telemetry and checking the Events section

The event shows up properly, and is even summarized properly to Keyed Scalars > Parent. I must be missing something.

:ewright Can you help me find out what I'm missing?

sorry for taking a while, I was on PTO. I'll see if I can duplicate it again.

Comment 4

[Chris H-C :chutten]

Did it happen to happen again? Or shall I close this down?

Comment 5

[Chris H-C :chutten]

Closing for now.

Comment 6

[Erica Wright [:ewright]]

:chutten, thank you, sorry I haven't had time try to reproduce this yet. I'll re-open if I can reproduce again.

Comment 7

[Mark Hammond [:markh] [:mhammond]]

I can reproduce this. In both artifact and non-artifact builds, EventArtifactDefinitions.json next to my locally built binary is not json - it's a c++ header file - ie, it starts with:

/* This file is auto-generated, only for internal use in TelemetryEvent.h,
   see gen_event_data.py. */

#ifndef mozilla_TelemetryEventData_h
#define mozilla_TelemetryEventData_h
#include "core/EventInfo.h"
namespace {

#if defined(_MSC_VER) && !defined(__clang__)
const uint32_t gExtraKeysTable[] = {
#else
constexpr uint32_t gExtraKeysTable[] = {
#endif

The key different between artifact and non-artifact builds is that presumably the latter always has up-to-date events builtin so doesn't care about loading dynamic ones at runtime.

The console always reports:

1574227665947	Toolkit.Telemetry	ERROR	TelemetryController::registerEventProbes - there was an error loading EventArtifactDefinitions.json: SyntaxError: JSON.parse: unexpected character at line 1 column 1 of the JSON data(resource://gre/modules/TelemetryController.jsm:1355:28) JS Stack trace: [e-mail]:1355:28
async*[e-mail]:1265:16
async*[e-mail]:740:43
[e-mail]:1001:21
[e-mail]:187:17
[e-mail]:31:25

which is a manifestation of the above. Note that after a 'build faster', this file does have the new probes - ie, that file is successfully getting rebuild when necessary - it's just the wrong file!

I'm on Windows which tends to be rare around here, so I wonder if that has anything to with the difficulty in others reproducing?

Comment 8

[Jan-Erik Rediger [:janerik]]

Attachment: Bug 1572758 - Fix generation of event artifact definitions caused by using the wrong entry point

Looks like this was mistakenly introduced here:
https://phabricator.services.mozilla.com/D48409#change-MERCC5y13iOg

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/77735f86efb6
Fix generation of event artifact definitions caused by using the wrong entry point r=chutten

Comment 10

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/77735f86efb6

Comment 11

[Release mgmt bot [:sylvestre / :calixte / :marco for bugbug]]

Since the status are different for nightly and release, what's the status for beta?
For more information, please visit auto_nag documentation.