Closed Bug 1572813 Opened 6 years ago Closed 3 years ago

GeckoView breaks Firefox Send service worker

Categories

(GeckoView :: General, defect, P2)

70 Branch
Unspecified
All
defect

Tracking

(firefox69 affected, firefox70 affected)

RESOLVED INCOMPLETE
Tracking Status
firefox69 --- affected
firefox70 --- affected

People

(Reporter: tigeroakes, Unassigned)

References

Details

(Whiteboard: [geckoview:m1910])

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:70.0) Gecko/20100101 Firefox/70.0

Steps to reproduce:

Try to download a file in Firefox Send

Actual results:

A 12-byte file just containing "Unauthorized" is downloaded.

Expected results:

The actual file should be downloaded.

Fenix has been having problems with Firefox Send (https://github.com/mozilla-mobile/fenix/issues/3336) and we've determined its an issue with the response we get from GeckoView, as the response is set to be 12 bytes before it reaches the Android Components downloader.

The Firefox Send team has stated that a similar issue happened with Safari. When a service worker set a Content-Disposition header in a response, the browser bypassed the service worker and made another request directly to the server.

If GeckoView has the same behaviour then the Send team can whitelist it like Safari.

I just tested this with a 100 Download limit send link and I can reproduce on Fenix (broken download) but not Fennec (downloads the file correctly)

James thinks this problem might be related to e10s, which is supported by Agi not being able to reproduce the bug in Fennec. James also suspects this problem is related to making two download requests in GV.

If GeckoView has the same behaviour then the Send team can whitelist it like Safari.

Should the Send team temporarily whitelist Fenix until we fix this GV bug? Should I move this bug to the "DOM::Service Workers" Bugzilla component?

To whitelist Fenix but not Fennec, Send can check the User-Agent string:

  • Gecko version <= 68 is Fennec.
  • Gecko version >= 69 is Fenix.
Status: UNCONFIRMED → NEW
Ever confirmed: true

Adding [geckoview:fenix:m9] whiteboard tag because the Fenix team would like this fix in Q4.

Priority: -- → P3
Whiteboard: [geckoview:fenix:m9]
Priority: P3 → P2

If GeckoView has the same behaviour then the Send team can whitelist it like Safari.

Tiger asked the Send team to temporarily whitelist Fenix until this (e10s?) Service Worker bug is fixed.

Rank: 15
Whiteboard: [geckoview:fenix:m9]

investigate in October

Priority: P2 → P1
Whiteboard: [geckoview:m1910]

We should confirm whether this is a GV download bug or a Service Worker bug (and then move this bug to the "DOM::Service Workers" Bugzilla component, if appropriate).

Here is the Firefox Send team's bug: https://github.com/mozilla/send/issues/1404

I will ask the Send team for an update on their workaround.

Priority: P1 → P2
Severity: normal → S3
Rank: 15 → 222

This bug is no longer relevant because Firefox Send has been discontinued.

Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.