1572836 - releasing off comm-esr68

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect)

Description

[Rob Lemley [:rjl]]

Will use this bug to track build config issues related to doing the initial release of Thunderbird 68.0 off comm-esr68.

First up, build signing issues due to comm-esr68 not being recognized as a release branch.

Comment 1

[Rob Lemley [:rjl]]

Attachment: signing_scope_release_branches_c-esr68.patch

Attaching so it can get into the THUNDERBIRD_68_VERBRANCH, will submit
to Phabricator for inclusion in M-C later.

Comment 2

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/releases/mozilla-esr68/rev/0d2d8881be5ea5d83959650122af2c355a360549 on THUNDERBIRD_68_VERBRANCH

Comment 3

[Rob Lemley [:rjl]]

Attachment: gdata-provider-artifact-filename.patch

This patch will not apply on c-c, as this particular change is already
present from work done in bug 1569539.

We may eventually uplift that bug, but it's pretty big and this is a relatively
safe change.

Try build successful with a beetmover upload:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=afcd4cf438775784f908ae1da2692cd5413637a6

Uploaded to:
http://ftp.stage.mozaws.net/pub/thunderbird/nightly/2019/08/2019-08-12-19-12-48-try-comm-central/gdata-provider.en-US.xpi

Comment 4

[Jorg K (CEST = GMT+2)]

Hmm, I think your talking about bug 1516816 and some of this: https://hg.mozilla.org/comm-central/rev/e1a0f9d5e69c#l1.12

Comment 5

[Rob Lemley [:rjl]]

Comment on attachment 9084854 [details] [diff] [review]
gdata-provider-artifact-filename.patch

This fixes the missing linux64-en-US builds from 68.0-build2.
Scriptworker does not expand variables in artifact filenames so '${locale}' needs to be dropped.

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: 
Testing completed (on c-c, etc.): tested on try-comm-central, including the beetmove job that currently fails on comm-esr68
Risk to taking this patch (and alternatives if risky):
Minimal risk, the end result of this change is gdata-provider.en-US.xpi is now named gdata-provider.xpi. Geoff this particular change is in C-C already. It should be mentioned in the release notes in case a downstream packager relies on that filename.

Comment 6

[Jorg K (CEST = GMT+2)]

Comment on attachment 9084854 [details] [diff] [review]
gdata-provider-artifact-filename.patch

I'll push it now.

Comment 7

[Rob Lemley [:rjl]]

(In reply to Jorg K (GMT+2) from comment #4)

Hmm, I think your talking about bug 1516816 and some of this: https://hg.mozilla.org/comm-central/rev/e1a0f9d5e69c#l1.12

Yes, but that was only needed because of the changes in bug 1569539.

Comment 8

[Jorg K (CEST = GMT+2)]

What are we going to do for beta when neither bug 1516816 nor bug 1569539 are going there? This hasn't been an issue on TB 69 beta for some reason. So we do nothing for that beta, right?

Comment 9

[Jorg K (CEST = GMT+2)]

TB 68.0 ESR:
https://hg.mozilla.org/releases/comm-esr68/rev/fcc993af647424b8cdbe43bb06eb222aa8d924eb

Comment 10

[Rob Lemley [:rjl]]

Ahh. This got messy. The first part of bug 1516816 is on beta: https://hg.mozilla.org/releases/comm-beta/rev/9344b60b89f062d9f49f916aca27b65180ee4f90, so it will run into the linux64-en-US bug.

Comment 11

[Jorg K (CEST = GMT+2)]

But we did not run into it for TB 69 beta 2, see: http://ftp.mozilla.org/pub/thunderbird/candidates/69.0b2-candidates/build1/linux-x86_64/en-US/

Comment 12

[Rob Lemley [:rjl]]

Okay so I'm not completely crazy then, because I remember checking that I could use a variable there...
https://searchfox.org/mozilla-beta/source/taskcluster/taskgraph/util/scriptworker.py#478-482

Beta can handle it, currently esr68 cannot.

Comment 13

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/releases/mozilla-esr68/rev/bc88b743dafde191d127f4150238a06c2595a227 on THUNDERBIRD_68_VERBRANCH for >= 68.1

Comment 14

[Geoff Lankow (:darktrojan)]

Attachment: 1572836-fetch-gdata-1.diff

This bug broke the tests. This patch should fix the tests. r+ from rjl on IRC.

Comment 15

[Jorg K (CEST = GMT+2)]

Comment on attachment 9090569 [details] [diff] [review]
1572836-fetch-gdata-1.diff

https://hg.mozilla.org/releases/comm-esr68/rev/3b8380bf4c660ed42b976cda98cbacb46c64e122
More gData fun :-(