Closed Bug 1572859 Opened 3 months ago Closed 3 months ago

Package more aggressively when building GeckoView (and Fennec) within Gradle

Categories

(GeckoView :: General, defect)

Unspecified
All
defect
Not set

Tracking

(firefox69 wontfix, firefox70 fixed)

RESOLVED FIXED
mozilla70
Tracking Status
firefox69 --- wontfix
firefox70 --- fixed

People

(Reporter: nalexander, Assigned: nalexander)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Right now, we produce omni.ja (and copy libxul.so, etc) in commands like ./mach android assemble-app only when certain files in mobile/android have changed. This makes sense for Fennec artifact builds: it updates the omnijar only when likely inputs to it have changed. But it doesn't make sense for GeckoView non-artifact builds: those want to pick up new libraries (i.e., libxul.so) basically every build.

It's difficult to get "real" dependencies for things that go into the libraries and the omnijar, either at the Make level or at the Gradle level. So this ticket tracks:

  • always packaging when invoked by Gradle (i.e., from within Android Studio)
  • accepting the few seconds of mach package-time
  • relying on Gradle's fingerprinting to know when AAR/APK targets are up to date

This should be much better for GeckoView engineers.

This always invokes mach package (in reality make -C ... stage-package for historical reasons), sacrificing a few seconds
of package-related time every Gradle build. We then rely on Gradle's
fingerprinting to know when AAR/APK targets are up to date.

This should be much better for GeckoView engineers: the old input file
computations were simplifications tuned for Fennec engineers consuming
artifact builds.

Pushed by nalexander@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4c1bdf45201a
Package more aggressively when building GeckoView (and Fennec) within Gradle. r=agi
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70

Assigning to Nick because he fixed this bug.

69=wontfix because we don't need to uplift to Beta.

Assignee: nobody → nalexander
You need to log in before you can comment on or make changes to this bug.