Closed
Bug 1572882
Opened 5 years ago
Closed 5 years ago
Inline Preview overlaps on the code in case of tab indentation
Categories
(DevTools :: Debugger, defect, P2)
DevTools
Debugger
Tracking
(firefox70 fixed)
RESOLVED
FIXED
Firefox 70
| Tracking | Status | |
|---|---|---|
| firefox70 | --- | fixed |
People
(Reporter: dhyey35, Assigned: davidwalsh)
References
Details
(Whiteboard: [debugger-reserve])
Attachments
(2 files, 1 obsolete file)
image (1).png
Inline preview feature works fine for space indented lines but for tab indented lines it breaks and starts overlapping the code.
|
Reporter | |
Updated•5 years ago
|
Blocks: dbg-inline-preview
|
Assignee | |
Comment 1•5 years ago
|
||
I'm wondering if this is a result of breakpoints/column breakpoints. Looking at our location code, it's taking line length & character width (+ 8px), but I don't think line length accommodates for column breakpoint markers.
|
|
Reporter | |
Comment 2•5 years ago
|
||
It happens even without them, although a nice case to consider. We should look out for this too
|
|
Assignee | |
Comment 3•5 years ago
|
||
Just a sketchup of an idea for preventing some overlap
|
||
Updated•5 years ago
|
|
||
Updated•5 years ago
|
Priority: -- → P2
|
||
Updated•5 years ago
|
Attachment #9085279 -
Attachment is obsolete: true
Pushed by dwalsh@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e2e07dd1956a Fix inline preview overlap, r=davidwalsh
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox70:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
|
||
Updated•5 years ago
|
Blocks: dbg-inline-preview-m1
|
|
||
Updated•5 years ago
|
No longer blocks: dbg-inline-preview
You need to log in
before you can comment on or make changes to this bug.
Description
•