Closed Bug 1572896 Opened 5 years ago Closed 5 years ago

Urlbar view contents are misaligned on internal Firefox pages

Categories

(Firefox :: Address Bar, defect, P1)

defect
Points:
2

Tracking

()

VERIFIED FIXED
Firefox 70
Iteration:
70.4 - Aug 19 - Sep 1
Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 --- unaffected
firefox68 --- unaffected
firefox69 --- unaffected
firefox70 --- fixed

People

(Reporter: adw, Assigned: adw)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Open an internal Firefox page like about:preferences and click the dropdown arrow in the urlbar. The urlbar view contents hug the left edge of the view.

The problem is that in this one case, pageproxystate is valid, but the identity icon is shown, not the tracking-protection icon.

I started working on a simple fix that would try the tracking protection icon and then the identity icon, but it seems like what we really want is to align to the input, not necessarily whatever icon happens to be in it. That doesn't work 100% though because there's a little padding between the icon and the left edge of the input. I'd like to think more about this next week.

Assignee: nobody → adw
Status: NEW → ASSIGNED
Iteration: --- → 70.4 - Aug 19 - Sep 1
Points: --- → 2
Pushed by dwillcoxon@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/71528ea79a0a
Align the quantumbar view's icons with the tracking protection or identity icon, whichever is visible. r=dao
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
Flags: qe-verify+

I have managed to reproduce te issue on Ubuntu using Fx 70.0a1 (2019-08-09) and I can confirm that the issue is fixed on Fx 70.0b11.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: